Issue 155623004: IDL compiler: [ReflectEmpty]

Issue 155623004: IDL compiler: [ReflectEmpty] (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)

Modified:
6 years, 10 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive, kouhei (in TOK)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

IDL compiler: [ReflectEmpty] Python side to: Empty reflected attributes and string literals in extended attributes. https://codereview.chromium.org/127903002/ Followup to: IDL compiler: [ReflectMissing], [ReflectInvalid] https://codereview.chromium.org/152043003/ This completes [Reflect*] extended attributes. I've got 2 cleanup CLs to do after this, which will simplify the CG. Remaining: 9 => 6 BUG=239771 R=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166464

Patch Set 1 #

Total comments: 3

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -4 lines)			Patch
M	Source/bindings/scripts/unstable/v8_attributes.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/templates/attributes.cpp	View	2 chunks	+15 lines, -2 lines	3 comments	Download
M	Source/bindings/tests/idls/TestObjectPython.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObjectPython.cpp	View	2 chunks	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/155623004/diff/1/Source/bindings/templates/attributes.cpp File Source/bindings/templates/attributes.cpp (right): https://codereview.chromium.org/155623004/diff/1/Source/bindings/templates/attributes.cpp#newcode116 Source/bindings/templates/attributes.cpp:116: {# FIXME: should use [ReflectEmpty] instead; need to ...

6 years, 10 months ago (2014-02-05 07:13:15 UTC) #2

Nils Barth (inactive)

https://codereview.chromium.org/155623004/diff/1/Source/bindings/templates/attributes.cpp File Source/bindings/templates/attributes.cpp (right): https://codereview.chromium.org/155623004/diff/1/Source/bindings/templates/attributes.cpp#newcode120 Source/bindings/templates/attributes.cpp:120: ; On 2014/02/05 07:13:15, haraken wrote: > What's this? ...

6 years, 10 months ago (2014-02-05 07:14:39 UTC) #3

Nils Barth (inactive)

The CQ bit was checked by nbarth@chromium.org

6 years, 10 months ago (2014-02-05 07:14:43 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/155623004/1

6 years, 10 months ago (2014-02-05 07:15:04 UTC) #5

Message was sent while issue was closed.

Change committed as 166464

Expand Messages | Collapse Messages