IDL compiler: [ReflectEmpty]

Source/bindings/templates/attributes.cpp

 {##############################################################################}
 {% macro attribute_getter(attribute, world_suffix) %}
 {% filter conditional(attribute.conditional_string) %}
 static void {{attribute.name}}AttributeGetter{{world_suffix}}(
 {%- if attribute.is_expose_js_accessors %}
 const v8::FunctionCallbackInfo<v8::Value>& info
 {%- else %}
 const v8::PropertyCallbackInfo<v8::Value>& info
 {%- endif %})
 {
@@ skipping 17 matching lines @@
             v8SetReturnValue(info, jsValue);
             return;
         }
     }
     {% elif not (attribute.is_static or attribute.is_unforgeable) %}
     {{cpp_class}}* imp = {{v8_class}}::toNative(info.Holder());
     {% endif %}
     {% if attribute.reflect_only %}
     {{attribute.cpp_type}} {{attribute.cpp_value}} = {{attribute.cpp_value_original}};
     {{release_only_check(attribute.reflect_only, attribute.reflect_missing,
-                         attribute.reflect_invalid) | indent}}
+                         attribute.reflect_invalid, attribute.reflect_empty)
+      | indent}}
     {% endif %}
     {% if attribute.is_call_with_execution_context %}
     ExecutionContext* scriptContext = currentExecutionContext(info.GetIsolate());
     {% endif %}
     {# Special cases #}
     {% if attribute.is_check_security_for_node or
           attribute.is_getter_raises_exception %}
     ExceptionState exceptionState(ExceptionState::GetterContext, "{{attribute.name}}", "{{interface_name}}", info.Holder(), info.GetIsolate());
     {% endif %}
     {% if attribute.is_check_security_for_node %}
@@ skipping 41 matching lines @@
     {% else %}
     {{attribute.v8_set_return_value}};
     {% endif %}
     {% endif %}
 }
 {% endfilter %}
 {% endmacro %}
 
 {######################################}
 {% macro release_only_check(reflect_only_values, reflect_missing,
-                            reflect_invalid) %}
+                            reflect_invalid, reflect_empty) %}
 {# Attribute is limited to only known values: check that the attribute value is
    one of those. If not, set it to the empty string.
    http://www.whatwg.org/specs/web-apps/current-work/#limited-to-only-known-values #}
-if (resultValue.isEmpty()) {
+{% if reflect_empty %}
+if (resultValue.isNull()) {
 {% if reflect_missing %}
     resultValue = "{{reflect_missing}}";
 {% else %}
     ;
 {% endif %}
+} else if (resultValue.isEmpty()) {
+    resultValue = "{{reflect_empty}}";
+{% else %}
+if (resultValue.isEmpty()) {
+{# FIXME: should use [ReflectEmpty] instead; need to change IDL files #}

[haraken, 2014/02/05 07:13:15]

Yeah, we should fix it.

+{% if reflect_missing %}
+    resultValue = "{{reflect_missing}}";
+{% else %}
+    ;

[haraken, 2014/02/05 07:13:15]

What's this?

[Nils Barth (inactive), 2014/02/05 07:14:39]

Perl generates an empty statement if there's no value.
This can also be removed, which I'll do during cleanup.

+{% endif %}
+{% endif %}
 {% for value in reflect_only_values %}
 } else if (equalIgnoringCase(resultValue, "{{value}}")) {
     resultValue = "{{value}}";
 {% endfor %}
 } else {
     resultValue = "{{reflect_invalid}}";
 }
 {% endmacro %}
 
 
@@ skipping 135 matching lines @@
     {% endif %}
     {% if attribute.has_custom_setter %}
     {{v8_class}}::{{attribute.name}}AttributeSetterCustom(jsValue, info);
     {% else %}
     {{cpp_class}}V8Internal::{{attribute.name}}AttributeSetter{{world_suffix}}(jsValue, info);
     {% endif %}
     TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
 }
 {% endfilter %}
 {% endmacro %}