Revert of Change extension icon load errors to warnings

Revert of Change extension icon load errors to warnings (patchset #8 id:140001 of https://codereview.chromium.org/1537473003/ )

Reason for revert:
file read from wrong thread

Original issue's description:
> Change extension icon load errors to warnings
>
> During the Extension parsing step, check if the icon file exists and if not, remove that entry from the dictionary.
>
> Keep the same check during the validation phase and don't apply the workaround to unpacked extensions. This will more strongly discourage new extensions from making this mistake.
>
> BUG=570249
>
> Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b
> Cr-Commit-Position: refs/heads/master@{#366253}

TBR=rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=570249
Committed: https://crrev.com/36dab10ffd04f3e38285bda1e4af07a7de081a31
Cr-Commit-Position: refs/heads/master@{#367080}

[Evan Stade, 2015-12-29 17:32:05]

Created Revert of Change extension icon load errors to warnings

[commit-bot: I haz the power, 2015-12-29 17:32:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1554583002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1554583002/1

[commit-bot: I haz the power, 2015-12-29 17:33:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-29 17:33:32]

Failed to apply patch for
chrome/browser/extensions/extension_action_manager_unittest.cc:
While running git apply --index -3 -p1;
  error: patch failed:
chrome/browser/extensions/extension_action_manager_unittest.cc:75
  Falling back to three-way merge...
  Applied patch to
'chrome/browser/extensions/extension_action_manager_unittest.cc' with conflicts.
  U chrome/browser/extensions/extension_action_manager_unittest.cc

Patch:       chrome/browser/extensions/extension_action_manager_unittest.cc
Index: chrome/browser/extensions/extension_action_manager_unittest.cc
diff --git a/chrome/browser/extensions/extension_action_manager_unittest.cc
b/chrome/browser/extensions/extension_action_manager_unittest.cc
index
76c47f1ecdace7ca77bf566fb1869c91fc2ac333..d040762d37393d54ca1abbaa935dc2706c9cc0fe
100644
--- a/chrome/browser/extensions/extension_action_manager_unittest.cc
+++ b/chrome/browser/extensions/extension_action_manager_unittest.cc
@@ -75,18 +75,15 @@
     DictionaryBuilder& action,
     const char* action_type) {
   std::string id = base::IntToString(curr_id_++);
-  scoped_refptr<Extension> extension =
-      ExtensionBuilder()
-          .SetManifest(
-              DictionaryBuilder()
-                  .Set("version", "1")
-                  .Set("manifest_version", 2)
-                  .Set("icons", extension_icons)
-                  .Set(action_type, action)
-                  .Set("name", std::string("Test Extension").append(id)))
-          .SetLocation(Manifest::UNPACKED)
-          .SetID(id)
-          .Build();
+  scoped_refptr<Extension> extension = ExtensionBuilder()
+      .SetManifest(DictionaryBuilder().Set("version", "1")
+          .Set("manifest_version", 2)
+          .Set("icons", extension_icons)
+          .Set(action_type, action)
+          .Set("name",
+              std::string("Test Extension").append(id)))
+      .SetID(id)
+      .Build();
   registry_->AddEnabled(extension);
   return extension;
 }

[commit-bot: I haz the power, 2015-12-29 17:33:46]

The CQ bit was unchecked by commit-bot@chromium.org

[Evan Stade, 2015-12-29 17:38:37]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-12-29 17:39:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1554583002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1554583002/300001

[Evan Stade, 2015-12-29 17:40:01]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2015-12-29 17:40:15]

Description was changed from

==========
Revert of Change extension icon load errors to warnings (patchset #8 id:140001
of https://codereview.chromium.org/1537473003/ )

Reason for revert:
file read from wrong thread

Original issue's description:
> Change extension icon load errors to warnings
> 
> During the Extension parsing step, check if the icon file exists and if not,
remove that entry from the dictionary.
> 
> Keep the same check during the validation phase and don't apply the workaround
to unpacked extensions. This will more strongly discourage new extensions from
making this mistake.
> 
> BUG=570249
> 
> Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b
> Cr-Commit-Position: refs/heads/master@{#366253}

TBR=rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=570249
==========

to

==========
Revert of Change extension icon load errors to warnings (patchset #8 id:140001
of https://codereview.chromium.org/1537473003/ )

Reason for revert:
file read from wrong thread

Original issue's description:
> Change extension icon load errors to warnings
> 
> During the Extension parsing step, check if the icon file exists and if not,
remove that entry from the dictionary.
> 
> Keep the same check during the validation phase and don't apply the workaround
to unpacked extensions. This will more strongly discourage new extensions from
making this mistake.
> 
> BUG=570249
> 
> Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b
> Cr-Commit-Position: refs/heads/master@{#366253}

TBR=rdevlin.cronin@chromium.org
NOPRESUBMIT=true
BUG=570249
==========

[commit-bot: I haz the power, 2015-12-29 17:40:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-29 17:40:17]

Description was changed from

==========
Revert of Change extension icon load errors to warnings (patchset #8 id:140001
of https://codereview.chromium.org/1537473003/ )

Reason for revert:
file read from wrong thread

Original issue's description:
> Change extension icon load errors to warnings
> 
> During the Extension parsing step, check if the icon file exists and if not,
remove that entry from the dictionary.
> 
> Keep the same check during the validation phase and don't apply the workaround
to unpacked extensions. This will more strongly discourage new extensions from
making this mistake.
> 
> BUG=570249
> 
> Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b
> Cr-Commit-Position: refs/heads/master@{#366253}

TBR=rdevlin.cronin@chromium.org
NOPRESUBMIT=true
BUG=570249
==========

to

==========
Revert of Change extension icon load errors to warnings (patchset #8 id:140001
of https://codereview.chromium.org/1537473003/ )

Reason for revert:
file read from wrong thread

Original issue's description:
> Change extension icon load errors to warnings
> 
> During the Extension parsing step, check if the icon file exists and if not,
remove that entry from the dictionary.
> 
> Keep the same check during the validation phase and don't apply the workaround
to unpacked extensions. This will more strongly discourage new extensions from
making this mistake.
> 
> BUG=570249
> 
> Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b
> Cr-Commit-Position: refs/heads/master@{#366253}

TBR=rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=570249
==========

[commit-bot: I haz the power, 2015-12-29 17:40:18]

Committed patchset #2 (id:300001)

[commit-bot: I haz the power, 2015-12-29 17:41:57]

Description was changed from

==========
Revert of Change extension icon load errors to warnings (patchset #8 id:140001
of https://codereview.chromium.org/1537473003/ )

Reason for revert:
file read from wrong thread

Original issue's description:
> Change extension icon load errors to warnings
> 
> During the Extension parsing step, check if the icon file exists and if not,
remove that entry from the dictionary.
> 
> Keep the same check during the validation phase and don't apply the workaround
to unpacked extensions. This will more strongly discourage new extensions from
making this mistake.
> 
> BUG=570249
> 
> Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b
> Cr-Commit-Position: refs/heads/master@{#366253}

TBR=rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=570249
==========

to

==========
Revert of Change extension icon load errors to warnings (patchset #8 id:140001
of https://codereview.chromium.org/1537473003/ )

Reason for revert:
file read from wrong thread

Original issue's description:
> Change extension icon load errors to warnings
>
> During the Extension parsing step, check if the icon file exists and if not,
remove that entry from the dictionary.
>
> Keep the same check during the validation phase and don't apply the workaround
to unpacked extensions. This will more strongly discourage new extensions from
making this mistake.
>
> BUG=570249
>
> Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b
> Cr-Commit-Position: refs/heads/master@{#366253}

TBR=rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=570249

Committed: https://crrev.com/36dab10ffd04f3e38285bda1e4af07a7de081a31
Cr-Commit-Position: refs/heads/master@{#367080}
==========

[commit-bot: I haz the power, 2015-12-29 17:41:58]

Patchset 2 (id:??) landed as
https://crrev.com/36dab10ffd04f3e38285bda1e4af07a7de081a31
Cr-Commit-Position: refs/heads/master@{#367080}

[Evan Stade, 2015-12-29 17:50:14]

A revert of this CL (patchset #2 id:300001) has been created in
https://codereview.chromium.org/1547413002/ by estade@chromium.org.

The reason for reverting is: this revert managed to break the tree.

[Evan Stade, 2015-12-29 18:00:15]

Description was changed from

==========
Revert of Change extension icon load errors to warnings (patchset #8 id:140001
of https://codereview.chromium.org/1537473003/ )

Reason for revert:
file read from wrong thread

Original issue's description:
> Change extension icon load errors to warnings
>
> During the Extension parsing step, check if the icon file exists and if not,
remove that entry from the dictionary.
>
> Keep the same check during the validation phase and don't apply the workaround
to unpacked extensions. This will more strongly discourage new extensions from
making this mistake.
>
> BUG=570249
>
> Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b
> Cr-Commit-Position: refs/heads/master@{#366253}

TBR=rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=570249

Committed: https://crrev.com/36dab10ffd04f3e38285bda1e4af07a7de081a31
Cr-Commit-Position: refs/heads/master@{#367080}
==========

to

==========
Revert of Change extension icon load errors to warnings (patchset #8 id:140001
of https://codereview.chromium.org/1537473003/ )

Reason for revert:
file read from wrong thread

Original issue's description:
> Change extension icon load errors to warnings
>
> During the Extension parsing step, check if the icon file exists and if not,
remove that entry from the dictionary.
>
> Keep the same check during the validation phase and don't apply the workaround
to unpacked extensions. This will more strongly discourage new extensions from
making this mistake.
>
> BUG=570249
>
> Committed: https://crrev.com/6e8e7d1c49657e82d0e8f2518ad463794346321b
> Cr-Commit-Position: refs/heads/master@{#366253}

TBR=rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=570249

Committed: https://crrev.com/36dab10ffd04f3e38285bda1e4af07a7de081a31
Cr-Commit-Position: refs/heads/master@{#367080}
==========

[Devlin, 2016-01-07 22:55:47]

We can close this, yeah?