extensions/common/file_util.h - Issue 1554583002: Revert of Change extension icon load errors to warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/file_util.h

Issue 1554583002: Revert of Change extension icon load errors to warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix merge issues Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/browser_action/multi_icons/manifest.json ('k') | extensions/common/file_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/file_util.h

diff --git a/extensions/common/file_util.h b/extensions/common/file_util.h

index 609b27ce3605fb48618e11c8e536709664140178..3fda56ad8f0d04e5e98548197d0e098c357fe557 100644

--- a/extensions/common/file_util.h

+++ b/extensions/common/file_util.h

@@ -72,9 +72,6 @@ scoped_ptr<base::DictionaryValue> LoadManifest(

const base::FilePath::CharType* manifest_filename,

std::string* error);

-// Returns true if the given file path exists and is not zero-length.

-bool ValidateFilePath(const base::FilePath& path);

// Returns true if the given extension object is valid and consistent.

// May also append a series of warning messages to |warnings|, but they

// should not prevent the extension from running.

« no previous file with comments | « chrome/test/data/extensions/api_test/browser_action/multi_icons/manifest.json ('k') | extensions/common/file_util.cc » ('j') | no next file with comments »