extensions/test/data/file_util/bad_icon/manifest.json - Issue 1554583002: Revert of Change extension icon load errors to warnings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/test/data/file_util/bad_icon/manifest.json

Issue 1554583002: Revert of Change extension icon load errors to warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix merge issues Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 {	1 {

2 "name": "My extension with a zero-length icon",	2 "name": "My extension with a zero-length icon",

3 "version": "1.0",	3 "version": "1.0",

4 "icons": {	4 "icons": {

5 "16": "good-icon.png",	5 "16": "icon.png"

6 "32": "missing-icon.png",

7 "64": "icon.png"

8 },	6 },

9 "manifest_version": 2	7 "manifest_version": 2

10 }	8 }

OLD	NEW

« no previous file with comments | « extensions/common/manifest_handlers/icons_handler.cc ('k') | extensions/utility/unpacker.cc » ('j') | no next file with comments »