Issue 155456: Try the original CL "Always persist bookmark IDs" again with the fix to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155456: Try the original CL "Always persist bookmark IDs" again with the fix to... (Closed)

Created:
11 years, 5 months ago by Munjal (Google)

Modified:
9 years ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Try the original CL "Always persist bookmark IDs" again with the fix to Valgrind issue. The fix is in bookmark_storage.h - initialized the newly added member ids_reassigned_ of LoadDetails class. See http://codereview.chromium.org/149310 for the original CL. TEST=NONE BUG=16068 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20565

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+195 lines, -195 lines)			Patch
M	chrome/browser/bookmarks/bookmark_codec.h	View	7 chunks	+20 lines, -18 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_codec.cc	View	9 chunks	+23 lines, -24 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_codec_unittest.cc	View	8 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_drag_data.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_drag_data.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model.h	View	9 chunks	+13 lines, -27 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model.cc	View	10 chunks	+14 lines, -45 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_storage.h	View	3 chunks	+11 lines, -5 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_storage.cc	View	5 chunks	+7 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/extension_bookmarks_module.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_bookmarks_module.cc	View	17 chunks	+60 lines, -28 lines	0 comments	Download
M	chrome/browser/extensions/extension_bookmarks_module_constants.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_bookmarks_module_constants.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_editor_gtk.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_manager_gtk.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_tree_model.h	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_tree_model.cc	View	5 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/views/bookmark_editor_view.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/bookmark_editor_view.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages