Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: chrome/browser/gtk/bookmark_manager_gtk.cc

Issue 155456: Try the original CL "Always persist bookmark IDs" again with the fix to... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/gtk/bookmark_editor_gtk.cc ('k') | chrome/browser/gtk/bookmark_tree_model.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/gtk/bookmark_manager_gtk.h" 5 #include "chrome/browser/gtk/bookmark_manager_gtk.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "app/l10n_util.h" 9 #include "app/l10n_util.h"
10 #include "app/resource_bundle.h" 10 #include "app/resource_bundle.h"
(...skipping 19 matching lines...) Expand all
30 #include "grit/theme_resources.h" 30 #include "grit/theme_resources.h"
31 31
32 namespace { 32 namespace {
33 33
34 // Number of bookmarks shown in recently bookmarked. 34 // Number of bookmarks shown in recently bookmarked.
35 const int kRecentlyBookmarkedCount = 50; 35 const int kRecentlyBookmarkedCount = 50;
36 36
37 // IDs for the recently added and search nodes. These values assume that node 37 // IDs for the recently added and search nodes. These values assume that node
38 // IDs will be strictly non-negative, which is an implementation detail of 38 // IDs will be strictly non-negative, which is an implementation detail of
39 // BookmarkModel, so this is sort of a hack. 39 // BookmarkModel, so this is sort of a hack.
40 const int kRecentID = -1; 40 const int64 kRecentID = -1;
41 const int kSearchID = -2; 41 const int64 kSearchID = -2;
42 42
43 // Padding between "Search:" and the entry field, in pixels. 43 // Padding between "Search:" and the entry field, in pixels.
44 const int kSearchPadding = 5; 44 const int kSearchPadding = 5;
45 45
46 // Time between a user action in the search box and when we perform the search. 46 // Time between a user action in the search box and when we perform the search.
47 const int kSearchDelayMS = 200; 47 const int kSearchDelayMS = 200;
48 48
49 // The default width of a column in the right tree view. Since we set the 49 // The default width of a column in the right tree view. Since we set the
50 // columns to ellipsize, if we don't explicitly set a width they will be 50 // columns to ellipsize, if we don't explicitly set a width they will be
51 // wide enough to display only '...'. This will be overridden if the user 51 // wide enough to display only '...'. This will be overridden if the user
(...skipping 1179 matching lines...) Expand 10 before | Expand all | Expand 10 after
1231 } else if (id == IDS_BOOKMARK_MANAGER_EXPORT_MENU) { 1231 } else if (id == IDS_BOOKMARK_MANAGER_EXPORT_MENU) {
1232 if (g_browser_process->io_thread()) { 1232 if (g_browser_process->io_thread()) {
1233 bookmark_html_writer::WriteBookmarks( 1233 bookmark_html_writer::WriteBookmarks(
1234 g_browser_process->io_thread()->message_loop(), model_, 1234 g_browser_process->io_thread()->message_loop(), model_,
1235 path.ToWStringHack()); 1235 path.ToWStringHack());
1236 } 1236 }
1237 } else { 1237 } else {
1238 NOTREACHED(); 1238 NOTREACHED();
1239 } 1239 }
1240 } 1240 }
OLDNEW
« no previous file with comments | « chrome/browser/gtk/bookmark_editor_gtk.cc ('k') | chrome/browser/gtk/bookmark_tree_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698