Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4445)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/extension_bookmarks_module.h

Issue 155456: Try the original CL "Always persist bookmark IDs" again with the fix to... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/bookmark_storage.cc ('k') | chrome/browser/extensions/extension_bookmarks_module.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_bookmarks_module.h
===================================================================
--- chrome/browser/extensions/extension_bookmarks_module.h (revision 20552)
+++ chrome/browser/extensions/extension_bookmarks_module.h (working copy)
@@ -70,6 +70,12 @@
virtual void Run();
virtual bool RunImpl() = 0;
+ protected:
+ // Helper to get the bookmark id as int64 from the given string id.
+ // Sets error_ to an errro string if the given id string can't be parsed
+ // as an int64. In case of error, doesn't change id and returns false.
+ bool GetBookmarkIdAsInt64(const std::string& id_string, int64* id);
+
private:
virtual void Observe(NotificationType type,
const NotificationSource& source,
« no previous file with comments | « chrome/browser/bookmarks/bookmark_storage.cc ('k') | chrome/browser/extensions/extension_bookmarks_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698