Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: pdf/pdf.cc

Issue 1554533002: Mark methods with override in pdf/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: How did pdf/ escape the wrath of the Clang plugin? Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pdf/pdf.cc
diff --git a/pdf/pdf.cc b/pdf/pdf.cc
index f52ee9732976198d34176333f38d2feac1ad76b5..fa43eaeb3c74ee5959201cd0806dc37fbdc5546c 100644
--- a/pdf/pdf.cc
+++ b/pdf/pdf.cc
@@ -104,8 +104,8 @@ bool RenderPDFPageToDC(const void* pdf_buffer,
return false;
}
}
- scoped_ptr<chrome_pdf::PDFEngineExports> engine_exports(
- chrome_pdf::PDFEngineExports::Create());
+ chrome_pdf::PDFEngineExports* engine_exports =
+ chrome_pdf::PDFEngineExports::Get();
chrome_pdf::PDFEngineExports::RenderingSettings settings(
dpi, dpi, pp::Rect(bounds_origin_x, bounds_origin_y, bounds_width,
bounds_height),
@@ -128,8 +128,8 @@ bool GetPDFDocInfo(const void* pdf_buffer,
if (!chrome_pdf::InitializeSDK())
return false;
}
- scoped_ptr<chrome_pdf::PDFEngineExports> engine_exports(
- chrome_pdf::PDFEngineExports::Create());
+ chrome_pdf::PDFEngineExports* engine_exports =
+ chrome_pdf::PDFEngineExports::Get();
bool ret = engine_exports->GetPDFDocInfo(
pdf_buffer, buffer_size, page_count, max_page_width);
if (!g_sdk_initialized_via_pepper) {
@@ -145,8 +145,8 @@ bool GetPDFPageSizeByIndex(const void* pdf_buffer,
if (!chrome_pdf::InitializeSDK())
return false;
}
- scoped_ptr<chrome_pdf::PDFEngineExports> engine_exports(
- chrome_pdf::PDFEngineExports::Create());
+ chrome_pdf::PDFEngineExports* engine_exports =
+ chrome_pdf::PDFEngineExports::Get();
bool ret = engine_exports->GetPDFPageSizeByIndex(
pdf_buffer, pdf_buffer_size, page_number, width, height);
if (!g_sdk_initialized_via_pepper)
@@ -166,8 +166,8 @@ bool RenderPDFPageToBitmap(const void* pdf_buffer,
if (!chrome_pdf::InitializeSDK())
return false;
}
- scoped_ptr<chrome_pdf::PDFEngineExports> engine_exports(
- chrome_pdf::PDFEngineExports::Create());
+ chrome_pdf::PDFEngineExports* engine_exports =
+ chrome_pdf::PDFEngineExports::Get();
chrome_pdf::PDFEngineExports::RenderingSettings settings(
dpi, dpi, pp::Rect(bitmap_width, bitmap_height), true, false, true, true,
autorotate);

Powered by Google App Engine
This is Rietveld 408576698