Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: tools/clang/plugins/ChromeClassTester.cpp

Issue 1554533002: Mark methods with override in pdf/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: How did pdf/ escape the wrath of the Clang plugin? Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pdf/out_of_process_instance.h ('K') | « pdf/preview_mode_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/ChromeClassTester.cpp
diff --git a/tools/clang/plugins/ChromeClassTester.cpp b/tools/clang/plugins/ChromeClassTester.cpp
index b39e14a0e2b08cfa8de907a4894c7af244cf1973..21db7ff2e7ed9a113055c5802ce45f8bb7fa0992 100644
--- a/tools/clang/plugins/ChromeClassTester.cpp
+++ b/tools/clang/plugins/ChromeClassTester.cpp
@@ -231,7 +231,6 @@ void ChromeClassTester::BuildBannedLists() {
banned_directories_.emplace("/native_client/");
banned_directories_.emplace("/breakpad/");
banned_directories_.emplace("/courgette/");
- banned_directories_.emplace("/pdf/");
Nico 2015/12/29 19:05:40 In general, we put changes like this behind a flag
Lei Zhang 2015/12/29 19:14:51 Sure, will do shortly.
banned_directories_.emplace("/ppapi/");
banned_directories_.emplace("/usr/include/");
banned_directories_.emplace("/usr/lib/");
« pdf/out_of_process_instance.h ('K') | « pdf/preview_mode_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698