pdf/out_of_process_instance.h - Issue 1554533002: Mark methods with override in pdf/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/out_of_process_instance.h

Issue 1554533002: Mark methods with override in pdf/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: How did pdf/ escape the wrath of the Clang plugin? Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pdf/out_of_process_instance.h

diff --git a/pdf/out_of_process_instance.h b/pdf/out_of_process_instance.h

index 41fef655159d2c3a7a57f53edc09d418e0303db6..f210d0a5a55bab8cef3761e2d5acabc9ffff5514 100644

--- a/pdf/out_of_process_instance.h

+++ b/pdf/out_of_process_instance.h

@@ -74,9 +74,8 @@ class OutOfProcessInstance : public pp::Instance,

bool IsPrintScalingDisabled() override;

// pp::Private implementation.

- virtual pp::Var GetLinkAtPosition(const pp::Point& point);

- virtual void GetPrintPresetOptionsFromDocument(

- PP_PdfPrintPresetOptions_Dev* options);

+ pp::Var GetLinkAtPosition(const pp::Point& point);

Nico 2015/12/29 19:03:27 ...shouldn't these be marked override?

Lei Zhang 2015/12/29 19:14:51 No, they implement the PPAPI functions from ppapi/

+ void GetPrintPresetOptionsFromDocument(PP_PdfPrintPresetOptions_Dev* options);

void FlushCallback(int32_t result);

void DidOpen(int32_t result);