Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1554443003: Stop linking in the old Mojo EDK. (Closed)

Created:
4 years, 11 months ago by jam
Modified:
4 years, 4 months ago
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, ben+mojo_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, sdefresne+watchlist_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, penghuang+watch-mandoline_chromium.org, chromium-apps-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, timvolodine, feature-media-reviews_chromium.org, kalyank, rjkroege, Aaron Boodman, mkwst+moarreviews-renderer_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop linking in the old Mojo EDK. BUG=561803

Patch Set 1 #

Patch Set 2 : git cl try #

Patch Set 3 : fix gyp #

Patch Set 4 : fix gn check #

Patch Set 5 : fix a bunch of unit test binaries to initialize new EDK correctly #

Patch Set 6 : merge after fixes in other cls #

Patch Set 7 : fixes #

Patch Set 8 : merge #

Patch Set 9 : fixes #

Patch Set 10 : fixes #

Patch Set 11 : fixes #

Patch Set 12 : fixes #

Patch Set 13 : fixes #

Patch Set 14 : fix linux 32 build #

Patch Set 15 : merge #

Patch Set 16 : merge and fix ios build #

Patch Set 17 : more fixes #

Patch Set 18 : more fixes #

Total comments: 1

Patch Set 19 : fix SerialConnectionTest.DisconnectWithSend #

Patch Set 20 : merge #

Patch Set 21 : fix MediaRouterMojoImplTest.RegisterAndUnregisterMediaSinksObserver and review nit #

Patch Set 22 : merge #

Patch Set 23 : merge #

Patch Set 24 : merge and fix new flaky test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+867 lines, -1166 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +6 lines, -20 lines 0 comments Download
M build/all.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +2 lines, -2 lines 0 comments Download
M build/gn_migration.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/media/router/media_router_mojo_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 11 chunks +60 lines, -23 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/run_all_unittests.cc View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M components/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -1 line 0 comments Download
M components/arc/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -1 line 0 comments Download
M components/arc/arc_bridge_bootstrap.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -9 lines 0 comments Download
M components/arc/arc_bridge_service_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +0 lines, -4 lines 0 comments Download
M components/arc/input/arc_input_bridge_impl.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -4 lines 0 comments Download
M components/html_viewer/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -2 lines 0 comments Download
M components/html_viewer/run_all_unittests.cc View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M components/mus/public/cpp/tests/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M components/test/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/test/run_all_unittests.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +6 lines, -4 lines 0 comments Download
M content/DEPS View 2 chunks +3 lines, -3 lines 0 comments Download
M content/app/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/app/mojo/mojo_init.cc View 2 chunks +10 lines, -17 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 2 3 4 5 6 7 3 chunks +11 lines, -18 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_arc_video_service_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/mojo/mojo_application_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +2 lines, -4 lines 0 comments Download
M content/browser/mojo/mojo_application_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 4 chunks +4 lines, -18 lines 0 comments Download
M content/browser/mojo/mojo_shell_client_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/mojo/mojo_shell_client_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 5 chunks +14 lines, -25 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 6 chunks +5 lines, -15 lines 0 comments Download
M content/child/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_thread_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -1 line 0 comments Download
M content/common/mojo/channel_init.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +0 lines, -17 lines 0 comments Download
M content/common/mojo/channel_init.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +7 lines, -36 lines 0 comments Download
M content/content_app.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -1 line 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 6 7 2 chunks +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 7 chunks +5 lines, -5 lines 0 comments Download
M content/public/test/render_view_test.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +4 lines, -6 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/mojo/service_registry_js_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 3 chunks +7 lines, -6 lines 0 comments Download
M content/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 6 chunks +5 lines, -5 lines 0 comments Download
M content/test/content_test_suite.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M content/test/content_test_suite.cc View 1 2 3 4 5 6 3 chunks +4 lines, -1 line 0 comments Download
M content/test/run_all_unittests.cc View 1 2 3 4 5 6 2 chunks +0 lines, -11 lines 0 comments Download
M device/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -1 line 0 comments Download
M device/battery/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/battery/battery.gyp View 1 chunk +1 line, -1 line 0 comments Download
M device/device_tests.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -1 line 0 comments Download
M device/serial/data_sink_receiver.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +2 lines, -2 lines 0 comments Download
M device/serial/data_sink_receiver.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +2 lines, -2 lines 0 comments Download
M device/test/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M device/test/run_all_unittests.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -2 lines 0 comments Download
M device/vibration/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/vibration/vibration.gyp View 1 chunk +1 line, -1 line 0 comments Download
M extensions/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/extensions_tests.gyp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/api_test_base.h View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/api_test_base.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M extensions/shell/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +1 line, -1 line 0 comments Download
M extensions/test/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M extensions/test/extensions_unittests_main.cc View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M ipc/attachment_broker.h View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -3 lines 0 comments Download
M ipc/attachment_broker.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M ipc/attachment_broker_mac_unittest.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/attachment_broker_privileged_win_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_test_base.h View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M ipc/ipc_test_base.cc View 1 2 3 4 5 6 4 chunks +9 lines, -4 lines 0 comments Download
M ipc/mojo/BUILD.gn View 4 chunks +3 lines, -11 lines 0 comments Download
M ipc/mojo/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/mojo/async_handle_waiter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/mojo/async_handle_waiter_unittest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
D ipc/mojo/client_channel.mojom View 1 chunk +0 lines, -9 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.h View 4 chunks +0 lines, -28 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 9 chunks +16 lines, -168 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_unittest.cc View 1 2 3 4 5 6 7 8 9 10 7 chunks +52 lines, -19 lines 0 comments Download
M ipc/mojo/ipc_mojo.gyp View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.h View 2 chunks +4 lines, -3 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.cc View 6 chunks +5 lines, -9 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_mojo_handle_attachment.cc View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M ipc/mojo/ipc_mojo_perftest.cc View 1 2 3 4 5 6 7 8 4 chunks +6 lines, -6 lines 0 comments Download
M ipc/mojo/run_all_unittests.cc View 1 2 3 4 5 6 2 chunks +22 lines, -2 lines 0 comments Download
M ipc/mojo/scoped_ipc_support.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/mojo/scoped_ipc_support.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M mandoline/app/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M mash/example/window_type_launcher/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +1 line, -1 line 0 comments Download
M mash/example/window_type_launcher/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mash/example/window_type_launcher/main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +7 lines, -10 lines 0 comments Download
M mash/wm/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +12 lines, -25 lines 0 comments Download
M mojo/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/android/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/android/javatests/init_library.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/common/BUILD.gn View 3 chunks +3 lines, -5 lines 0 comments Download
M mojo/converters/surfaces/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/embedder/BUILD.gn View 1 2 3 6 chunks +21 lines, -16 lines 0 comments Download
M mojo/edk/embedder/embedder.h View 1 2 3 4 3 chunks +6 lines, -1 line 0 comments Download
M mojo/edk/embedder/embedder.cc View 1 2 3 4 4 chunks +7 lines, -8 lines 0 comments Download
M mojo/edk/embedder/embedder_internal.h View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M mojo/edk/embedder/entrypoints.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +25 lines, -5 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 1 5 chunks +10 lines, -27 lines 0 comments Download
M mojo/edk/system/core_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 4 chunks +22 lines, -0 lines 0 comments Download
M mojo/edk/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +26 lines, -28 lines 0 comments Download
M mojo/edk/test/multiprocess_test_helper.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/edk/test/multiprocess_test_helper.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/edk/test/run_all_perftests.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/edk/test/run_all_unittests.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/mojo.gyp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/mojo_base.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +36 lines, -8 lines 0 comments Download
M mojo/mojo_edk.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 6 chunks +29 lines, -27 lines 0 comments Download
M mojo/mojo_edk_tests.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 7 chunks +36 lines, -17 lines 0 comments Download
M mojo/mojo_shell.gyp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M mojo/platform_handle/BUILD.gn View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M mojo/platform_handle/platform_handle_functions.cc View 1 2 3 1 chunk +7 lines, -12 lines 0 comments Download
M mojo/public/c/system/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/child/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/child/runner_connection.cc View 4 chunks +28 lines, -42 lines 0 comments Download
M mojo/runner/child/test_native_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +14 lines, -17 lines 0 comments Download
M mojo/runner/context.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/runner/context.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +5 lines, -8 lines 0 comments Download
M mojo/runner/desktop/launcher_process.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/runner/host/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/host/child_process.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 8 chunks +36 lines, -51 lines 0 comments Download
M mojo/runner/host/child_process_host.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -11 lines 0 comments Download
M mojo/runner/host/child_process_host.cc View 1 2 3 4 5 6 7 5 chunks +18 lines, -35 lines 0 comments Download
M mojo/runner/host/child_process_host_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +0 lines, -23 lines 0 comments Download
M mojo/runner/host/host_unittests.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -3 lines 0 comments Download
M mojo/shell/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/application_manager_apptest_driver.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +21 lines, -34 lines 0 comments Download
M mojo/shell/fetcher/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/package_manager/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/tests/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/shell_application_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +5 lines, -4 lines 0 comments Download
M net/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M net/DEPS View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -1 line 0 comments Download
M net/test/run_all_unittests.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +7 lines, -3 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/mojo/mojo_edk_tests.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 10 chunks +14 lines, -24 lines 0 comments Download
M third_party/mojo/mojo_variables.gypi View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
M tools/ipc_fuzzer/message_replay/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M tools/ipc_fuzzer/message_replay/replay_process.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (14 generated)
jam
4 years, 11 months ago (2016-01-12 23:16:38 UTC) #13
Ben Goodger (Google)
lgtm https://codereview.chromium.org/1554443003/diff/530001/content/common/mojo/channel_init.h File content/common/mojo/channel_init.h (right): https://codereview.chromium.org/1554443003/diff/530001/content/common/mojo/channel_init.h#newcode35 content/common/mojo/channel_init.h:35: // TODO(jam); remove this nit: colon
4 years, 11 months ago (2016-01-12 23:31:00 UTC) #14
jam
4 years, 11 months ago (2016-01-14 00:27:46 UTC) #17 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698