Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: mojo/edk/system/BUILD.gn

Issue 1554443003: Stop linking in the old Mojo EDK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge and fix new flaky test Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/embedder/entrypoints.cc ('k') | mojo/edk/system/core_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/BUILD.gn
diff --git a/mojo/edk/system/BUILD.gn b/mojo/edk/system/BUILD.gn
index cd58ff40a5a974f4c1be72adc0613285b316a736..2b410533b7bc7d0544adabf873eb81afe8bde778 100644
--- a/mojo/edk/system/BUILD.gn
+++ b/mojo/edk/system/BUILD.gn
@@ -17,13 +17,8 @@ config("system_config") {
]
}
-static_library("system") {
- # TODO(use_chrome_edk): this should be a component to match third_party,
- # but since third_party includes it, we either make it a static library
- # or we have to change the export macros to be different than third_party.
- #component("system") {
- # TODO(use_chrome_edk): remove "2"
- output_name = "mojo_system_impl2"
+component("system") {
+ output_name = "mojo_system_impl"
sources = [
"async_waiter.cc",
@@ -114,9 +109,8 @@ static_library("system") {
group("tests") {
testonly = true
deps = [
- # TODO(use_chrome_edk): remove "2"
- ":mojo_message_pipe_perftests2",
- ":mojo_system_unittests2",
+ ":mojo_message_pipe_perftests",
+ ":mojo_system_unittests",
]
}
@@ -141,8 +135,7 @@ source_set("test_utils") {
]
}
-# TODO(use_chrome_edk): remove "2"
-test("mojo_system_unittests2") {
+test("mojo_system_unittests") {
sources = [
"../test/multiprocess_test_helper_unittest.cc",
"awakable_list_unittest.cc",
@@ -171,27 +164,20 @@ test("mojo_system_unittests2") {
deps = [
":test_utils",
-
- # TODO(use_chrome_edk): remove "2"
"../../../mojo/public/cpp/environment:standalone",
- "../embedder:embedder_unittests2",
+ "../embedder:embedder_unittests",
"../test:test_support",
"//base",
"//base/test:test_support",
+ "//mojo/edk/system",
"//mojo/edk/test:run_all_unittests",
"//testing/gtest",
-
- # TODO(use_chrome_edk): temporary since the Mojo wrapper primitives are
- # declared in third party only for now.
- "//third_party/mojo/src/mojo/edk/system",
]
- # TODO(use_chrome_edk): remove "2"
- allow_circular_includes_from = [ "../embedder:embedder_unittests2" ]
+ allow_circular_includes_from = [ "../embedder:embedder_unittests" ]
}
-# TODO(use_chrome_edk): remove "2"
-test("mojo_message_pipe_perftests2") {
+test("mojo_message_pipe_perftests") {
sources = [
"message_pipe_perftest.cc",
"message_pipe_test_utils.cc",
@@ -205,10 +191,7 @@ test("mojo_message_pipe_perftests2") {
"../test:test_support",
"//base",
"//base/test:test_support",
+ "//mojo/edk/system",
"//testing/gtest",
-
- # TODO(use_chrome_edk): temporary since the Mojo wrapper primitives are
- # declared in third party only for now.
- "//third_party/mojo/src/mojo/edk/system",
]
}
« no previous file with comments | « mojo/edk/embedder/entrypoints.cc ('k') | mojo/edk/system/core_test_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698