Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: content/browser/browser_child_process_host_impl.cc

Issue 1554443003: Stop linking in the old Mojo EDK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge and fix new flaky test Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/app/mojo/mojo_init.cc ('k') | content/browser/browser_main_loop.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_child_process_host_impl.cc
diff --git a/content/browser/browser_child_process_host_impl.cc b/content/browser/browser_child_process_host_impl.cc
index 9461b624195aac8202566de0a5b26ceee8181ef5..36d83362c544c153c52a8d69621f6fc8977b0a54 100644
--- a/content/browser/browser_child_process_host_impl.cc
+++ b/content/browser/browser_child_process_host_impl.cc
@@ -35,7 +35,8 @@
#include "content/public/common/result_codes.h"
#include "ipc/attachment_broker.h"
#include "ipc/attachment_broker_privileged.h"
-#include "third_party/mojo/src/mojo/edk/embedder/embedder.h"
+#include "mojo/edk/embedder/embedder.h"
+#include "mojo/edk/embedder/scoped_platform_handle.h"
#if defined(OS_MACOSX)
#include "content/browser/mach_broker_mac.h"
@@ -195,7 +196,6 @@ void BrowserChildProcessHostImpl::Launch(
switches::kTraceToConsole,
switches::kV,
switches::kVModule,
- "use-new-edk", // TODO(use_chrome_edk): temporary.
};
cmd_line->CopySwitchesFrom(browser_command_line, kForwardSwitches,
arraysize(kForwardSwitches));
@@ -414,25 +414,18 @@ void BrowserChildProcessHostImpl::OnProcessLaunched() {
const base::Process& process = child_process_->GetProcess();
DCHECK(process.IsValid());
- if (base::CommandLine::ForCurrentProcess()->HasSwitch("use-new-edk")) {
- mojo::embedder::ScopedPlatformHandle client_pipe;
+ mojo::edk::ScopedPlatformHandle client_pipe;
#if defined(MOJO_SHELL_CLIENT)
- if (IsRunningInMojoShell()) {
- client_pipe = RegisterProcessWithBroker(process.Pid());
- } else
+ if (IsRunningInMojoShell()) {
+ client_pipe = RegisterProcessWithBroker(process.Pid());
+ } else
#endif
- {
- client_pipe = mojo::embedder::ChildProcessLaunched(process.Handle());
- }
- Send(new ChildProcessMsg_SetMojoParentPipeHandle(
- IPC::GetFileHandleForProcess(
-#if defined(OS_WIN)
- client_pipe.release().handle,
-#else
- client_pipe.release().fd,
-#endif
- process.Handle(), true)));
+ {
+ client_pipe = mojo::edk::ChildProcessLaunched(process.Handle());
}
+ Send(new ChildProcessMsg_SetMojoParentPipeHandle(
+ IPC::GetFileHandleForProcess(client_pipe.release().handle,
+ process.Handle(), true)));
#if defined(OS_WIN)
// Start a WaitableEventWatcher that will invoke OnProcessExitedEarly if the
« no previous file with comments | « content/app/mojo/mojo_init.cc ('k') | content/browser/browser_main_loop.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698