Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 155441: Nukes the 3 arg TabMoved variant in favor of the 4 arg variant.... (Closed)

Created:
11 years, 5 months ago by sky
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, Erik does not do reviews, Ben Goodger (Google)
Visibility:
Public.

Description

Nukes the 3 arg TabMoved variant in favor of the 4 arg variant. BUG=16634 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20581

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -25 lines) Patch
M chrome/browser/browser.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/browser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/tab_strip_model_observer_bridge.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/tab_strip_model_observer_bridge.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_browser_event_router.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_browser_event_router.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/gtk/tabs/tab_strip_gtk.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/gtk/tabs/tab_strip_gtk.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tabs/tab_strip_model.h View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/views/tabs/browser_tab_strip.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/views/tabs/browser_tab_strip.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_overview_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_overview_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_strip.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
11 years, 5 months ago (2009-07-13 21:21:46 UTC) #1
Ben Goodger (Google)
11 years, 5 months ago (2009-07-13 22:53:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698