Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Side by Side Diff: chrome/browser/cocoa/tab_strip_model_observer_bridge.mm

Issue 155441: Nukes the 3 arg TabMoved variant in favor of the 4 arg variant.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/cocoa/tab_strip_model_observer_bridge.h" 5 #include "chrome/browser/cocoa/tab_strip_model_observer_bridge.h"
6 6
7 TabStripModelObserverBridge::TabStripModelObserverBridge(TabStripModel* model, 7 TabStripModelObserverBridge::TabStripModelObserverBridge(TabStripModel* model,
8 id controller) 8 id controller)
9 : controller_(controller), model_(model) { 9 : controller_(controller), model_(model) {
10 DCHECK(model && controller); 10 DCHECK(model && controller);
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 userGesture:)]) { 54 userGesture:)]) {
55 [controller_ selectTabWithContents:new_contents 55 [controller_ selectTabWithContents:new_contents
56 previousContents:old_contents 56 previousContents:old_contents
57 atIndex:index 57 atIndex:index
58 userGesture:user_gesture]; 58 userGesture:user_gesture];
59 } 59 }
60 } 60 }
61 61
62 void TabStripModelObserverBridge::TabMoved(TabContents* contents, 62 void TabStripModelObserverBridge::TabMoved(TabContents* contents,
63 int from_index, 63 int from_index,
64 int to_index) { 64 int to_index,
65 bool pinned_state_changed) {
65 if ([controller_ respondsToSelector: 66 if ([controller_ respondsToSelector:
66 @selector(tabMovedWithContents:fromIndex:toIndex:)]) { 67 @selector(tabMovedWithContents:fromIndex:toIndex:)]) {
67 [controller_ tabMovedWithContents:contents 68 [controller_ tabMovedWithContents:contents
68 fromIndex:from_index 69 fromIndex:from_index
69 toIndex:to_index]; 70 toIndex:to_index];
70 } 71 }
71 } 72 }
72 73
73 void TabStripModelObserverBridge::TabChangedAt(TabContents* contents, 74 void TabStripModelObserverBridge::TabChangedAt(TabContents* contents,
74 int index, 75 int index,
75 bool loading_only) { 76 bool loading_only) {
76 if ([controller_ respondsToSelector: 77 if ([controller_ respondsToSelector:
77 @selector(tabChangedWithContents:atIndex:loadingOnly:)]) { 78 @selector(tabChangedWithContents:atIndex:loadingOnly:)]) {
78 [controller_ tabChangedWithContents:contents 79 [controller_ tabChangedWithContents:contents
79 atIndex:index 80 atIndex:index
80 loadingOnly:loading_only ? YES : NO]; 81 loadingOnly:loading_only ? YES : NO];
81 } 82 }
82 } 83 }
83 84
84 void TabStripModelObserverBridge::TabStripEmpty() { 85 void TabStripModelObserverBridge::TabStripEmpty() {
85 if ([controller_ respondsToSelector:@selector(tabStripEmpty)]) 86 if ([controller_ respondsToSelector:@selector(tabStripEmpty)])
86 [controller_ tabStripEmpty]; 87 [controller_ tabStripEmpty];
87 } 88 }
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/tab_strip_model_observer_bridge.h ('k') | chrome/browser/extensions/extension_browser_event_router.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698