Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1622)

Unified Diff: chrome/browser/tabs/tab_strip_model.h

Issue 155441: Nukes the 3 arg TabMoved variant in favor of the 4 arg variant.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/tabs/tab_strip_gtk.cc ('k') | chrome/browser/views/tabs/browser_tab_strip.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tabs/tab_strip_model.h
===================================================================
--- chrome/browser/tabs/tab_strip_model.h (revision 20500)
+++ chrome/browser/tabs/tab_strip_model.h (working copy)
@@ -72,20 +72,12 @@
int index,
bool user_gesture) { }
- // The specified TabContents at |from_index| was moved to |to_index|.
- // TODO(sky): nuke and convert all to 4 arg variant.
- virtual void TabMoved(TabContents* contents,
- int from_index,
- int to_index) { }
-
// The specified TabContents at |from_index| was moved to |to_index|. If
// the pinned state of the tab is changing |pinned_state_changed| is true.
virtual void TabMoved(TabContents* contents,
int from_index,
int to_index,
- bool pinned_state_changed) {
- TabMoved(contents, from_index, to_index);
- }
+ bool pinned_state_changed) { }
// The specified TabContents at |index| changed in some way. |contents| may
// be an entirely different object and the old value is no longer available
« no previous file with comments | « chrome/browser/gtk/tabs/tab_strip_gtk.cc ('k') | chrome/browser/views/tabs/browser_tab_strip.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698