Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1553493002: Global conversion of Pass()→std::move() on OS=linux chromecast=1 (Closed)

Created:
4 years, 12 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
Avi (use Gerrit), Nico
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, eme-reviews_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, ozone-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, sievers+watch_chromium.org, tdresser+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Global conversion of Pass()→std::move() on OS=linux chromecast=1 (╯^□^)╯︵ ❄☃❄ BUG=557422 R=avi@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/a3c693e216157a8fddaa5080b503d35f7f9c2745 Cr-Commit-Position: refs/heads/master@{#367050}

Patch Set 1 #

Patch Set 2 : fix header #

Patch Set 3 : Fix fragile include order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -85 lines) Patch
M base/feature_list_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_request.cc View 2 chunks +2 lines, -1 line 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_requester.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.cc View 2 chunks +3 lines, -1 line 0 comments Download
M cloud_print/gcp20/prototype/privet_http_server.cc View 10 chunks +10 lines, -9 lines 0 comments Download
M content/browser/compositor/browser_compositor_overlay_candidate_validator_ozone.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M content/common/discardable_shared_memory_heap_perftest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_pixmap.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/media/cdm/proxy_media_keys.cc View 7 chunks +10 lines, -9 lines 0 comments Download
M content/renderer/media/cdm/renderer_cdm_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M google_apis/drive/files_list_request_runner_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M media/blink/resource_multibuffer_data_provider_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M media/formats/common/stream_parser_test_base.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/formats/mp2t/mp2t_stream_parser.cc View 5 chunks +14 lines, -12 lines 0 comments Download
M media/formats/mp4/avc.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/formats/mp4/box_definitions.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M media/formats/mp4/hevc.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/formats/mp4/mp4_stream_parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc View 1 2 3 chunks +8 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/event_thread_evdev.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M ui/events/ozone/evdev/input_injector_evdev.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
dcheng
Turns out I need to fix the Chromecast build first too before I can consider ...
4 years, 12 months ago (2015-12-28 23:51:40 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553493002/1
4 years, 12 months ago (2015-12-28 23:53:35 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/124233)
4 years, 12 months ago (2015-12-29 00:16:08 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553493002/20001
4 years, 12 months ago (2015-12-29 00:18:33 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/124243)
4 years, 12 months ago (2015-12-29 00:47:05 UTC) #11
Avi (use Gerrit)
lgtm stampity stamp
4 years, 12 months ago (2015-12-29 03:04:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553493002/40001
4 years, 12 months ago (2015-12-29 03:06:37 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 12 months ago (2015-12-29 04:19:58 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/a3c693e216157a8fddaa5080b503d35f7f9c2745 Cr-Commit-Position: refs/heads/master@{#367050}
4 years, 12 months ago (2015-12-29 04:21:18 UTC) #17
Nico
4 years, 11 months ago (2015-12-29 12:01:35 UTC) #19
Message was sent while issue was closed. 
..\..\cloud_print\gcp20\prototype\privet_http_server.cc(38,10) :  error: moving
a local object in a return statement prevents copy elision
[-Werror,-Wpessimizing-move]
  return std::move(error);
         ^

…and many more in this file:
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/5360/ste...

We should probably build cloud_print with chromium_code: 1?

Powered by Google App Engine
This is Rietveld 408576698