cloud_print/gcp20/prototype/cloud_print_requester.cc - Issue 1553493002: Global conversion of Pass()→std::move() on OS=linux chromecast=1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/gcp20/prototype/cloud_print_requester.cc

Issue 1553493002: Global conversion of Pass()→std::move() on OS=linux chromecast=1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix fragile include order Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cloud_print/gcp20/prototype/cloud_print_request.cc ('k') | cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cloud_print/gcp20/prototype/cloud_print_requester.cc

diff --git a/cloud_print/gcp20/prototype/cloud_print_requester.cc b/cloud_print/gcp20/prototype/cloud_print_requester.cc

index 9b94a384fb69463a0d13316b47c6346aca3f9d07..b32456c3083795b221c86cf074f2afcd8d5bb495 100644

--- a/cloud_print/gcp20/prototype/cloud_print_requester.cc

+++ b/cloud_print/gcp20/prototype/cloud_print_requester.cc

@@ -5,8 +5,8 @@

#include "cloud_print/gcp20/prototype/cloud_print_requester.h"

#include <stdint.h>

#include <limits>

+#include <utility>

#include "base/bind.h"

#include "base/json/json_writer.h"

@@ -90,7 +90,7 @@ std::string LocalSettingsToJson(const LocalSettings& settings) {

current->SetBoolean("printer/local_printing_enabled",

settings.local_printing_enabled);

current->SetInteger("xmpp_timeout_value", settings.xmpp_timeout_value);

- dictionary.Set("current", current.Pass());

+ dictionary.Set("current", std::move(current));

std::string local_settings;

base::JSONWriter::Write(dictionary, &local_settings);