Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1553463002: Only verify in-object fields in fast properties case. (Closed)

Created:
4 years, 12 months ago by Benedikt Meurer
Modified:
4 years, 12 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Only verify in-object fields in fast properties case. This matches the behavior of JSObject::JSObjectVerify() and seems to be the current contract for --verify-heap. BUG=chromium:572590 LOG=n Committed: https://crrev.com/2fcf3aa62cfbd57be3013df77aaf2083cd4f3de6 Cr-Commit-Position: refs/heads/master@{#33056}

Patch Set 1 #

Patch Set 2 : Ignition cannot deal with the test case yet. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/objects-debug.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-572590.js View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Benedikt Meurer
Hey Camillo, Making clusterfuzz happy. Please take a look. Thanks, Benedikt
4 years, 12 months ago (2015-12-28 20:21:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553463002/20001
4 years, 12 months ago (2015-12-29 05:12:34 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-29 05:50:59 UTC) #6
Camillo Bruni
lgtm
4 years, 12 months ago (2015-12-29 09:31:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553463002/20001
4 years, 12 months ago (2015-12-29 11:18:32 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 12 months ago (2015-12-29 11:20:08 UTC) #10
commit-bot: I haz the power
4 years, 12 months ago (2015-12-29 11:21:01 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2fcf3aa62cfbd57be3013df77aaf2083cd4f3de6
Cr-Commit-Position: refs/heads/master@{#33056}

Powered by Google App Engine
This is Rietveld 408576698