Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: src/objects-debug.cc

Issue 1553463002: Only verify in-object fields in fast properties case. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ignition cannot deal with the test case yet. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/mjsunit.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/objects.h" 5 #include "src/objects.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/disasm.h" 8 #include "src/disasm.h"
9 #include "src/disassembler.h" 9 #include "src/disassembler.h"
10 #include "src/macro-assembler.h" 10 #include "src/macro-assembler.h"
(...skipping 531 matching lines...) Expand 10 before | Expand all | Expand 10 after
542 542
543 void SlicedString::SlicedStringVerify() { 543 void SlicedString::SlicedStringVerify() {
544 CHECK(!this->parent()->IsConsString()); 544 CHECK(!this->parent()->IsConsString());
545 CHECK(!this->parent()->IsSlicedString()); 545 CHECK(!this->parent()->IsSlicedString());
546 CHECK(this->length() >= SlicedString::kMinLength); 546 CHECK(this->length() >= SlicedString::kMinLength);
547 } 547 }
548 548
549 549
550 void JSBoundFunction::JSBoundFunctionVerify() { 550 void JSBoundFunction::JSBoundFunctionVerify() {
551 CHECK(IsJSBoundFunction()); 551 CHECK(IsJSBoundFunction());
552 VerifyObjectField(kLengthOffset); 552 if (HasFastProperties()) {
553 VerifyObjectField(kNameOffset); 553 VerifyObjectField(kLengthOffset);
554 VerifyObjectField(kNameOffset);
555 }
554 VerifyObjectField(kBoundThisOffset); 556 VerifyObjectField(kBoundThisOffset);
555 VerifyObjectField(kBoundTargetFunctionOffset); 557 VerifyObjectField(kBoundTargetFunctionOffset);
556 VerifyObjectField(kBoundArgumentsOffset); 558 VerifyObjectField(kBoundArgumentsOffset);
557 VerifyObjectField(kCreationContextOffset); 559 VerifyObjectField(kCreationContextOffset);
558 CHECK(bound_target_function()->IsCallable()); 560 CHECK(bound_target_function()->IsCallable());
559 CHECK(creation_context()->IsNativeContext()); 561 CHECK(creation_context()->IsNativeContext());
560 CHECK(IsCallable()); 562 CHECK(IsCallable());
561 CHECK_EQ(IsConstructor(), bound_target_function()->IsConstructor()); 563 CHECK_EQ(IsConstructor(), bound_target_function()->IsConstructor());
562 } 564 }
563 565
(...skipping 770 matching lines...) Expand 10 before | Expand all | Expand 10 after
1334 1336
1335 // Both are done at the same time. 1337 // Both are done at the same time.
1336 CHECK_EQ(new_it.done(), old_it.done()); 1338 CHECK_EQ(new_it.done(), old_it.done());
1337 } 1339 }
1338 1340
1339 1341
1340 #endif // DEBUG 1342 #endif // DEBUG
1341 1343
1342 } // namespace internal 1344 } // namespace internal
1343 } // namespace v8 1345 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/mjsunit.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698