Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/objects-debug.cc

Issue 1553463002: Only verify in-object fields in fast properties case. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ignition cannot deal with the test case yet. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/mjsunit.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index a57d6e633b89509e07280067a4282d16a544c486..dbfe33aee10326101f9e48d2bbcf774114019f4d 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -549,8 +549,10 @@ void SlicedString::SlicedStringVerify() {
void JSBoundFunction::JSBoundFunctionVerify() {
CHECK(IsJSBoundFunction());
- VerifyObjectField(kLengthOffset);
- VerifyObjectField(kNameOffset);
+ if (HasFastProperties()) {
+ VerifyObjectField(kLengthOffset);
+ VerifyObjectField(kNameOffset);
+ }
VerifyObjectField(kBoundThisOffset);
VerifyObjectField(kBoundTargetFunctionOffset);
VerifyObjectField(kBoundArgumentsOffset);
« no previous file with comments | « no previous file | test/mjsunit/mjsunit.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698