Add package config support to dart:isolate

Add package config support to dart:isolate

- Add "static Future<Uri> get packageRoot;",
  "static Future<Uri> get packageConfig;" and
  "static Future<Uri> resolvePackageUri(Uri packageUri)" to Isolate class.
- Added "Uri packageRoot, Uri packageConfig, bool automaticPackageResolution: false" parameters to spawnUri.

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/6d066c7e53f82b70c3a5bfc4916d8a0c9a26a6f4

[Ivan Posva, 2016-01-04 21:08:21]

Description was changed from

==========
- Add "static Future<Uri> get packageRoot;" to Isolate.
- (WIP) Start adding support for additional parameters in spawnUri.



BUG=
==========

to

==========
- Add "static Future<Uri> get packageRoot;" and
  "static Future<Uri> get packageConfig;" to Isolate class.
- (WIP) Start adding support for additional parameters in spawnUri.

BUG=
==========

[Ivan Posva, 2016-01-12 23:53:41]

Description was changed from

==========
- Add "static Future<Uri> get packageRoot;" and
  "static Future<Uri> get packageConfig;" to Isolate class.
- (WIP) Start adding support for additional parameters in spawnUri.

BUG=
==========

to

==========
- Add "static Future<Uri> get packageRoot;",
  "static Future<Uri> get packageConfig;" and 
  "static Future<Uri> resolvePackageUri(Uri packageUri)" to Isolate class.
- Added "Uri packageRoot, Uri packageConfig, bool automaticPackageResolution:
false" parameters to spawnUri.

BUG=
==========

[Ivan Posva, 2016-01-12 23:59:17]

iposva@google.com changed reviewers:
+ lrn@google.com, rmacnak@google.com

[rmacnak, 2016-01-13 01:39:00]

https://codereview.chromium.org/1553233002/diff/100001/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

https://codereview.chromium.org/1553233002/diff/100001/runtime/bin/dartutils....
runtime/bin/dartutils.cc:661: const char* packages_file) {
packages_file -> package_config

https://codereview.chromium.org/1553233002/diff/100001/runtime/bin/dartutils....
runtime/bin/dartutils.cc:763: const char* packages_file,
packages_file -> package_config

https://codereview.chromium.org/1553233002/diff/100001/runtime/bin/dartutils....
runtime/bin/dartutils.cc:797: packages_file);
packages_file -> package_config

https://codereview.chromium.org/1553233002/diff/100001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/1553233002/diff/100001/runtime/bin/main.cc#ne...
runtime/bin/main.cc:707: const char* packages_file,
packages_file -> package_config

https://codereview.chromium.org/1553233002/diff/100001/runtime/bin/main.cc#ne...
runtime/bin/main.cc:770: packages_file,
packages_file -> package_config

https://codereview.chromium.org/1553233002/diff/100001/runtime/lib/isolate_pa...
File runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/1553233002/diff/100001/runtime/lib/isolate_pa...
runtime/lib/isolate_patch.dart:352: throw new ArgumentError("Cannot
simultaneously request "
I don't see a test for these.

https://codereview.chromium.org/1553233002/diff/100001/sdk/lib/isolate/isolat...
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/1553233002/diff/100001/sdk/lib/isolate/isolat...
sdk/lib/isolate/isolate.dart:136: */
Note how this value can differ from Platform.packageRoot.

https://codereview.chromium.org/1553233002/diff/100001/sdk/lib/isolate/isolat...
sdk/lib/isolate/isolate.dart:140: * Returns the package root of the current
isolate, if any.
package root => location of the package config

https://codereview.chromium.org/1553233002/diff/100001/sdk/lib/isolate/isolat...
sdk/lib/isolate/isolate.dart:145: */
Note how this value can differ from Platform.packageConfig.

https://codereview.chromium.org/1553233002/diff/100001/sdk/lib/isolate/isolat...
sdk/lib/isolate/isolate.dart:152: * isolate, then this call returns `null`.
Non-package: URI are
Non-package: URIs

https://codereview.chromium.org/1553233002/diff/100001/tests/standalone/stand...
File tests/standalone/standalone.status (right):

https://codereview.chromium.org/1553233002/diff/100001/tests/standalone/stand...
tests/standalone/standalone.status:15:
package/scenarios/invalid/same_package_twice_test.dart: Fail, OK #
CompileTimeErrors intentionally
Fail -> CompileTimeError

[kevmoo, 2016-01-13 01:40:18]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2016-01-13 01:40:18]

DBC

https://codereview.chromium.org/1553233002/diff/100001/sdk/lib/isolate/isolat...
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/1553233002/diff/100001/sdk/lib/isolate/isolat...
sdk/lib/isolate/isolate.dart:265: external static Future<Isolate> spawnUri(
Document the new arguments

[kevmoo, 2016-01-13 01:40:45]

Description was changed from

==========
- Add "static Future<Uri> get packageRoot;",
  "static Future<Uri> get packageConfig;" and 
  "static Future<Uri> resolvePackageUri(Uri packageUri)" to Isolate class.
- Added "Uri packageRoot, Uri packageConfig, bool automaticPackageResolution:
false" parameters to spawnUri.

BUG=
==========

to

==========
Add package config support to dart:isolate

- Add "static Future<Uri> get packageRoot;",
  "static Future<Uri> get packageConfig;" and 
  "static Future<Uri> resolvePackageUri(Uri packageUri)" to Isolate class.
- Added "Uri packageRoot, Uri packageConfig, bool automaticPackageResolution:
false" parameters to spawnUri.

BUG=
==========

[Ivan Posva, 2016-01-13 02:13:15]

PTAL -ip

https://codereview.chromium.org/1553233002/diff/100001/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

https://codereview.chromium.org/1553233002/diff/100001/runtime/bin/dartutils....
runtime/bin/dartutils.cc:661: const char* packages_file) {
On 2016/01/13 01:38:59, rmacnak wrote:
> packages_file -> package_config

Done.

https://codereview.chromium.org/1553233002/diff/100001/runtime/bin/dartutils....
runtime/bin/dartutils.cc:763: const char* packages_file,
On 2016/01/13 01:38:59, rmacnak wrote:
> packages_file -> package_config

Done.

https://codereview.chromium.org/1553233002/diff/100001/runtime/bin/dartutils....
runtime/bin/dartutils.cc:797: packages_file);
On 2016/01/13 01:38:59, rmacnak wrote:
> packages_file -> package_config

Done.

https://codereview.chromium.org/1553233002/diff/100001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/1553233002/diff/100001/runtime/bin/main.cc#ne...
runtime/bin/main.cc:707: const char* packages_file,
On 2016/01/13 01:38:59, rmacnak wrote:
> packages_file -> package_config

Done.

https://codereview.chromium.org/1553233002/diff/100001/runtime/bin/main.cc#ne...
runtime/bin/main.cc:770: packages_file,
On 2016/01/13 01:38:59, rmacnak wrote:
> packages_file -> package_config

Done.

https://codereview.chromium.org/1553233002/diff/100001/runtime/lib/isolate_pa...
File runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/1553233002/diff/100001/runtime/lib/isolate_pa...
runtime/lib/isolate_patch.dart:352: throw new ArgumentError("Cannot
simultaneously request "
On 2016/01/13 01:39:00, rmacnak wrote:
> I don't see a test for these.

Added.

https://codereview.chromium.org/1553233002/diff/100001/sdk/lib/isolate/isolat...
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/1553233002/diff/100001/sdk/lib/isolate/isolat...
sdk/lib/isolate/isolate.dart:152: * isolate, then this call returns `null`.
Non-package: URI are
On 2016/01/13 01:39:00, rmacnak wrote:
> Non-package: URIs

Done.

https://codereview.chromium.org/1553233002/diff/100001/sdk/lib/isolate/isolat...
sdk/lib/isolate/isolate.dart:265: external static Future<Isolate> spawnUri(
On 2016/01/13 01:40:18, kevmoo wrote:
> Document the new arguments

Done.

https://codereview.chromium.org/1553233002/diff/100001/tests/standalone/stand...
File tests/standalone/standalone.status (right):

https://codereview.chromium.org/1553233002/diff/100001/tests/standalone/stand...
tests/standalone/standalone.status:15:
package/scenarios/invalid/same_package_twice_test.dart: Fail, OK #
CompileTimeErrors intentionally
On 2016/01/13 01:39:00, rmacnak wrote:
> Fail -> CompileTimeError

Bad comment. Actually these are RuntimeErrors.

[rmacnak, 2016-01-13 02:16:07]

lgtm

[Ivan Posva, 2016-01-13 02:19:07]

Description was changed from

==========
Add package config support to dart:isolate

- Add "static Future<Uri> get packageRoot;",
  "static Future<Uri> get packageConfig;" and 
  "static Future<Uri> resolvePackageUri(Uri packageUri)" to Isolate class.
- Added "Uri packageRoot, Uri packageConfig, bool automaticPackageResolution:
false" parameters to spawnUri.

BUG=
==========

to

==========
Add package config support to dart:isolate

- Add "static Future<Uri> get packageRoot;",
  "static Future<Uri> get packageConfig;" and
  "static Future<Uri> resolvePackageUri(Uri packageUri)" to Isolate class.
- Added "Uri packageRoot, Uri packageConfig, bool automaticPackageResolution:
false" parameters to spawnUri.

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6d066c7e53f82b70c3a5bfc4916d8a0c9a26a6f4
==========

[Ivan Posva, 2016-01-13 02:19:09]

Committed patchset #7 (id:120001) manually as
6d066c7e53f82b70c3a5bfc4916d8a0c9a26a6f4 (presubmit successful).

[kevmoo, 2016-01-13 02:21:19]

A few more questions on the doc commetns

https://codereview.chromium.org/1553233002/diff/120001/sdk/lib/isolate/isolat...
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/1553233002/diff/120001/sdk/lib/isolate/isolat...
sdk/lib/isolate/isolate.dart:256: *
Need notes on the behavior if both `packageRoot` and `packageConfig` are
provided

https://codereview.chromium.org/1553233002/diff/120001/sdk/lib/isolate/isolat...
sdk/lib/isolate/isolate.dart:257: * If the [automaticPackageResolution]
parameter is provided, then the
provided => `true`.

https://codereview.chromium.org/1553233002/diff/120001/sdk/lib/isolate/isolat...
sdk/lib/isolate/isolate.dart:259: * determined.
determined how?

How does this relate to packageRoot and packageConfig?