runtime/bin/vmservice_dartium.cc - Issue 1553233002: Add package config support to dart:isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice_dartium.cc

Issue 1553233002: Add package config support to dart:isolate (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Addressed review comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/vmservice_dartium.cc

diff --git a/runtime/bin/vmservice_dartium.cc b/runtime/bin/vmservice_dartium.cc

index 0ff30a7b6f2ecdf8ac9a58800a1b4dbba7776f98..cd2c87fb7b1c9f8642e105c46b8e3cfca9ca114e 100644

--- a/runtime/bin/vmservice_dartium.cc

+++ b/runtime/bin/vmservice_dartium.cc

@@ -68,7 +68,7 @@ Dart_Isolate VmServiceServer::CreateIsolate(const uint8_t* snapshot_buffer) {

// Prepare for script loading by setting up the 'print' and 'timer'

// closures and setting up 'package root' for URI resolution.

result = DartUtils::PrepareForScriptLoading(

- NULL, NULL, NULL, true, false, builtin_lib);

+ NULL, NULL, true, false, builtin_lib);

CHECK_RESULT(result);

ASSERT(Dart_IsServiceIsolate(isolate));