Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: sdk/lib/_internal/js_runtime/lib/isolate_patch.dart

Issue 1553233002: Add package config support to dart:isolate (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Addressed review comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
diff --git a/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart b/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
index ac8b5376327552810cd99fd3dbee3c95eabfbc7d..79931ba3039fc1ecb99f22516e6c19d3cb74bccf 100644
--- a/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
+++ b/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
@@ -20,6 +20,21 @@ class Isolate {
static Isolate get current => _currentIsolateCache;
@patch
+ static Future<Uri> get packageRoot {
+ throw new UnsupportedError("Isolate.packageRoot");
+ }
+
+ @patch
+ static Future<Uri> get packageConfig {
+ throw new UnsupportedError("Isolate.packageConfig");
+ }
+
+ @patch
+ static Future<Uri> resolvePackageUri(Uri packageUri) {
+ throw new UnsupportedError("Isolate.resolvePackageUri");
+ }
+
+ @patch
static Future<Isolate> spawn(void entryPoint(message), var message,
{bool paused: false, bool errorsAreFatal,
SendPort onExit, SendPort onError}) {
@@ -66,9 +81,14 @@ class Isolate {
bool errorsAreFatal,
bool checked,
Map<String, String> environment,
- Uri packageRoot}) {
+ Uri packageRoot,
+ Uri packageConfig,
+ bool automaticPackageResolution: false}) {
if (environment != null) throw new UnimplementedError("environment");
if (packageRoot != null) throw new UnimplementedError("packageRoot");
+ if (packageConfig != null) throw new UnimplementedError("packageConfig");
+ // TODO(lrn): Figure out how to handle the automaticPackageResolution
+ // parameter.
bool forcePause = (errorsAreFatal != null) ||
(onExit != null) ||
(onError != null);

Powered by Google App Engine
This is Rietveld 408576698