Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 1551993003: Remove lib.target from search paths in adb_gdb and symbol.py (Closed)

Created:
4 years, 11 months ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove lib.target from search paths in adb_gdb and symbol.py lib.target is used when building with make, which we don't do anymore. BUG=573347 Committed: https://crrev.com/1dea8dee5f372a03416fcc26faf15f2b0cb716c6 Cr-Commit-Position: refs/heads/master@{#367315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M build/android/adb_gdb View 2 chunks +7 lines, -8 lines 0 comments Download
M third_party/android_platform/development/scripts/symbol.py View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
agrieve
◕‿-
4 years, 11 months ago (2015-12-31 02:21:47 UTC) #2
rmcilroy
LGTM, thanks.
4 years, 11 months ago (2016-01-04 10:12:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551993003/1
4 years, 11 months ago (2016-01-04 16:20:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 16:39:22 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 16:40:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1dea8dee5f372a03416fcc26faf15f2b0cb716c6
Cr-Commit-Position: refs/heads/master@{#367315}

Powered by Google App Engine
This is Rietveld 408576698