Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Side by Side Diff: third_party/android_platform/development/scripts/symbol.py

Issue 1551993003: Remove lib.target from search paths in adb_gdb and symbol.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/adb_gdb ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # 2 #
3 # Copyright (C) 2013 The Android Open Source Project 3 # Copyright (C) 2013 The Android Open Source Project
4 # 4 #
5 # Licensed under the Apache License, Version 2.0 (the "License"); 5 # Licensed under the Apache License, Version 2.0 (the "License");
6 # you may not use this file except in compliance with the License. 6 # you may not use this file except in compliance with the License.
7 # You may obtain a copy of the License at 7 # You may obtain a copy of the License at
8 # 8 #
9 # http://www.apache.org/licenses/LICENSE-2.0 9 # http://www.apache.org/licenses/LICENSE-2.0
10 # 10 #
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 logging.debug('MapDeviceApkToLibrary: matching_apks=%s' % matching_apks) 294 logging.debug('MapDeviceApkToLibrary: matching_apks=%s' % matching_apks)
295 for matching_apk in matching_apks: 295 for matching_apk in matching_apks:
296 crazy_lib = GetCrazyLib(matching_apk) 296 crazy_lib = GetCrazyLib(matching_apk)
297 if crazy_lib: 297 if crazy_lib:
298 return crazy_lib 298 return crazy_lib
299 299
300 def GetLibrarySearchPaths(): 300 def GetLibrarySearchPaths():
301 if CHROME_SYMBOLS_DIR: 301 if CHROME_SYMBOLS_DIR:
302 return [CHROME_SYMBOLS_DIR] 302 return [CHROME_SYMBOLS_DIR]
303 dirs = _GetChromeOutputDirCandidates() 303 dirs = _GetChromeOutputDirCandidates()
304 return PathListJoin(dirs, ['lib.unstripped', 'lib', 'lib.target', '.']) 304 # GYP places unstripped libraries under out/$BUILDTYPE/lib
305 # GN places them under out/$BUILDTYPE/lib.unstripped
306 return PathListJoin(dirs, ['lib.unstripped', 'lib', '.'])
305 307
306 def GetCandidateLibraries(library_name): 308 def GetCandidateLibraries(library_name):
307 """Returns a list of candidate library filenames. 309 """Returns a list of candidate library filenames.
308 310
309 Args: 311 Args:
310 library_name: basename of the library to match. 312 library_name: basename of the library to match.
311 313
312 Returns: 314 Returns:
313 A list of matching library filenames for library_name. 315 A list of matching library filenames for library_name.
314 """ 316 """
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
606 process.stdin.write("\n") 608 process.stdin.write("\n")
607 process.stdin.close() 609 process.stdin.close()
608 demangled_symbol = process.stdout.readline().strip() 610 demangled_symbol = process.stdout.readline().strip()
609 process.stdout.close() 611 process.stdout.close()
610 return demangled_symbol 612 return demangled_symbol
611 613
612 def FormatSymbolWithOffset(symbol, offset): 614 def FormatSymbolWithOffset(symbol, offset):
613 if offset == 0: 615 if offset == 0:
614 return symbol 616 return symbol
615 return "%s+%d" % (symbol, offset) 617 return "%s+%d" % (symbol, offset)
OLDNEW
« no previous file with comments | « build/android/adb_gdb ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698