Add --output-dir, CHROMIUM_OUTPUT_DIR to adb_gdb

Add --output-dir, CHROMIUM_OUTPUT_DIR to adb_gdb

Most other scripts support these already.

BUG=573345
Committed: https://crrev.com/0f29ea462bfc1842cab03f6b373ff02d60a02305
Cr-Commit-Position: refs/heads/master@{#368252}

[agrieve, 2015-12-31 02:22:30]

Description was changed from

==========
Add --output-dir, CHROMIUM_OUTPUT_DIR to adb_gdb

Most other scripts support these already.

BUG=573345
==========

to

==========
Add --output-dir, CHROMIUM_OUTPUT_DIR to adb_gdb

Most other scripts support these already.

BUG=573345
==========

[agrieve, 2015-12-31 02:22:30]

agrieve@chromium.org changed reviewers:
+ pasko@chromium.org

[agrieve, 2015-12-31 02:22:35]

On 2015/12/31 02:22:30, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:pasko@chromium.org

◕‿-

[pasko, 2016-01-04 10:51:12]

WDYT about the proposal from thakis@? let's continue the discussion on the bug

[agrieve, 2016-01-07 15:08:16]

On 2016/01/04 10:51:12, pasko wrote:
> WDYT about the proposal from thakis@? let's continue the discussion on the bug

OKay to move forward with this?

[pasko, 2016-01-07 16:11:38]

lgtm with a few minor suggestions.

Suggestion #1: s/these/this/ in the commit description.

https://codereview.chromium.org/1559573003/diff/1/build/android/adb_gdb
File build/android/adb_gdb (right):

https://codereview.chromium.org/1559573003/diff/1/build/android/adb_gdb#newco...
build/android/adb_gdb:699: #
plz mention using $BUILDTYPE as input

https://codereview.chromium.org/1559573003/diff/1/build/android/adb_gdb#newco...
build/android/adb_gdb:710: PARENT_DIR="${CHROMIUM_OUT_DIR}"
please remove curly braces for consistency

https://codereview.chromium.org/1559573003/diff/1/build/android/adb_gdb#newco...
build/android/adb_gdb:742: panic "Could not find any build directory under \
passing 2 params looks nicer:

if [[ -z "$SUBDIR" ]]; then
  panic "Could not find any build directory under" \
      "$PARENT_DIR/{${SUBDIRS/ /,}}. Please build the program first!"
fi

https://codereview.chromium.org/1559573003/diff/1/build/android/adb_gdb#newco...
build/android/adb_gdb:743: $PARENT_DIR/{${SUBDIRS/ /,}}. Please build the
program first!"
${SUBDIRS/ /,} would only replace the first space with comma, is that
intentional?

[agrieve, 2016-01-08 02:07:30]

https://codereview.chromium.org/1559573003/diff/1/build/android/adb_gdb
File build/android/adb_gdb (right):

https://codereview.chromium.org/1559573003/diff/1/build/android/adb_gdb#newco...
build/android/adb_gdb:699: #
On 2016/01/07 16:11:38, pasko wrote:
> plz mention using $BUILDTYPE as input

Done.

https://codereview.chromium.org/1559573003/diff/1/build/android/adb_gdb#newco...
build/android/adb_gdb:710: PARENT_DIR="${CHROMIUM_OUT_DIR}"
On 2016/01/07 16:11:38, pasko wrote:
> please remove curly braces for consistency

Done.

https://codereview.chromium.org/1559573003/diff/1/build/android/adb_gdb#newco...
build/android/adb_gdb:742: panic "Could not find any build directory under \
On 2016/01/07 16:11:38, pasko wrote:
> passing 2 params looks nicer:
> 
> if [[ -z "$SUBDIR" ]]; then
>   panic "Could not find any build directory under" \
>       "$PARENT_DIR/{${SUBDIRS/ /,}}. Please build the program first!"
> fi

Done.

https://codereview.chromium.org/1559573003/diff/1/build/android/adb_gdb#newco...
build/android/adb_gdb:743: $PARENT_DIR/{${SUBDIRS/ /,}}. Please build the
program first!"
On 2016/01/07 16:11:38, pasko wrote:
> ${SUBDIRS/ /,} would only replace the first space with comma, is that
> intentional?

Nope! Fixed.

[agrieve, 2016-01-08 02:07:40]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-01-08 02:07:40]

The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org
Link to the patchset: https://codereview.chromium.org/1559573003/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2016-01-08 02:08:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1559573003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1559573003/20001

[commit-bot: I haz the power, 2016-01-08 02:50:27]

Description was changed from

==========
Add --output-dir, CHROMIUM_OUTPUT_DIR to adb_gdb

Most other scripts support these already.

BUG=573345
==========

to

==========
Add --output-dir, CHROMIUM_OUTPUT_DIR to adb_gdb

Most other scripts support these already.

BUG=573345
==========

[commit-bot: I haz the power, 2016-01-08 02:50:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-08 02:52:15]

Description was changed from

==========
Add --output-dir, CHROMIUM_OUTPUT_DIR to adb_gdb

Most other scripts support these already.

BUG=573345
==========

to

==========
Add --output-dir, CHROMIUM_OUTPUT_DIR to adb_gdb

Most other scripts support these already.

BUG=573345

Committed: https://crrev.com/0f29ea462bfc1842cab03f6b373ff02d60a02305
Cr-Commit-Position: refs/heads/master@{#368252}
==========

[commit-bot: I haz the power, 2016-01-08 02:52:16]

Patchset 2 (id:??) landed as
https://crrev.com/0f29ea462bfc1842cab03f6b373ff02d60a02305
Cr-Commit-Position: refs/heads/master@{#368252}