Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1551953003: Disable -check_heap_mismatch for 64-bit Dr. Memory (Closed)

Created:
4 years, 11 months ago by Derek Bruening
Modified:
4 years, 11 months ago
Reviewers:
zhaoqin1
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable -check_heap_mismatch for 64-bit Dr. Memory Disables Dr. Memory's -check_heap_mismatch feature on 64-bit Chromium, where some false positives are proving difficult to solve. TBR=zhaoqin@chromium.org BUG=https://github.com/DynamoRIO/drmemory/issues/1839 Committed: https://crrev.com/36ac036574aa4fd4d5a99d04895151d265ac1414 Cr-Commit-Position: refs/heads/master@{#367234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/valgrind/valgrind_test.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Derek Bruening
4 years, 11 months ago (2015-12-31 06:04:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551953003/1
4 years, 11 months ago (2015-12-31 06:05:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-31 06:49:08 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2015-12-31 06:50:06 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36ac036574aa4fd4d5a99d04895151d265ac1414
Cr-Commit-Position: refs/heads/master@{#367234}

Powered by Google App Engine
This is Rietveld 408576698