Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: tools/valgrind/valgrind_test.py

Issue 1551953003: Disable -check_heap_mismatch for 64-bit Dr. Memory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Runs an exe through Valgrind and puts the intermediate files in a 5 """Runs an exe through Valgrind and puts the intermediate files in a
6 directory. 6 directory.
7 """ 7 """
8 8
9 import datetime 9 import datetime
10 import glob 10 import glob
(...skipping 701 matching lines...) Expand 10 before | Expand all | Expand 10 after
712 # disable leak scan for now 712 # disable leak scan for now
713 proc += ["-no_count_leaks", "-no_leak_scan"] 713 proc += ["-no_count_leaks", "-no_leak_scan"]
714 714
715 # disable warnings about unaddressable prefetches 715 # disable warnings about unaddressable prefetches
716 proc += ["-no_check_prefetch"] 716 proc += ["-no_check_prefetch"]
717 717
718 # crbug.com/413215, no heap mismatch check for Windows release build binary 718 # crbug.com/413215, no heap mismatch check for Windows release build binary
719 if common.IsWindows() and "Release" in self._options.build_dir: 719 if common.IsWindows() and "Release" in self._options.build_dir:
720 proc += ["-no_check_delete_mismatch"] 720 proc += ["-no_check_delete_mismatch"]
721 721
722 # We are seeing false positive invalid heap args on 64-bit, so we are
723 # disabling the feature for now (xref
724 # https://github.com/DynamoRIO/drmemory/issues/1839).
725 if common.IsWindows() and "Release_x64" in self._options.build_dir:
726 proc += ["-no_check_heap_mismatch"]
727
722 # make callstacks easier to read 728 # make callstacks easier to read
723 proc += ["-callstack_srcfile_prefix", 729 proc += ["-callstack_srcfile_prefix",
724 "build\\src,chromium\\src,crt_build\\self_x86"] 730 "build\\src,chromium\\src,crt_build\\self_x86"]
725 proc += ["-callstack_modname_hide", 731 proc += ["-callstack_modname_hide",
726 "*drmemory*,chrome.dll"] 732 "*drmemory*,chrome.dll"]
727 733
728 boring_callers = common.BoringCallers(mangled=False, use_re_wildcards=False) 734 boring_callers = common.BoringCallers(mangled=False, use_re_wildcards=False)
729 # TODO(timurrrr): In fact, we want "starting from .." instead of "below .." 735 # TODO(timurrrr): In fact, we want "starting from .." instead of "below .."
730 proc += ["-callstack_truncate_below", ",".join(boring_callers)] 736 proc += ["-callstack_truncate_below", ",".join(boring_callers)]
731 737
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
825 return DrMemory(False, True) 831 return DrMemory(False, True)
826 try: 832 try:
827 platform_name = common.PlatformNames()[0] 833 platform_name = common.PlatformNames()[0]
828 except common.NotImplementedError: 834 except common.NotImplementedError:
829 platform_name = sys.platform + "(Unknown)" 835 platform_name = sys.platform + "(Unknown)"
830 raise RuntimeError, "Unknown tool (tool=%s, platform=%s)" % (tool_name, 836 raise RuntimeError, "Unknown tool (tool=%s, platform=%s)" % (tool_name,
831 platform_name) 837 platform_name)
832 838
833 def CreateTool(tool): 839 def CreateTool(tool):
834 return ToolFactory().Create(tool) 840 return ToolFactory().Create(tool)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698