Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: tools/valgrind/valgrind_test.py

Issue 1551953003: Disable -check_heap_mismatch for 64-bit Dr. Memory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/valgrind_test.py
diff --git a/tools/valgrind/valgrind_test.py b/tools/valgrind/valgrind_test.py
index 9f132c8414a7272f423a7cb62b742ac13a7dd60d..0ca3c605cd89dbe4d68d3f7a42575da64a2d417a 100644
--- a/tools/valgrind/valgrind_test.py
+++ b/tools/valgrind/valgrind_test.py
@@ -719,6 +719,12 @@ class DrMemory(BaseTool):
if common.IsWindows() and "Release" in self._options.build_dir:
proc += ["-no_check_delete_mismatch"]
+ # We are seeing false positive invalid heap args on 64-bit, so we are
+ # disabling the feature for now (xref
+ # https://github.com/DynamoRIO/drmemory/issues/1839).
+ if common.IsWindows() and "Release_x64" in self._options.build_dir:
+ proc += ["-no_check_heap_mismatch"]
+
# make callstacks easier to read
proc += ["-callstack_srcfile_prefix",
"build\\src,chromium\\src,crt_build\\self_x86"]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698