blimp/net/browser_connection_handler.h - Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/net/browser_connection_handler.h

Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dtrainor-linux-cl1528243002

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/net/browser_connection_handler.h

diff --git a/blimp/net/browser_connection_handler.h b/blimp/net/browser_connection_handler.h

index 5a4b2390680530f12df8b45a36f61a96834ce28b..2cba6e67e9810f77a5d0eff96fb7ed3656f6917d 100644

--- a/blimp/net/browser_connection_handler.h

+++ b/blimp/net/browser_connection_handler.h

@@ -48,8 +48,6 @@ class BLIMP_NET_EXPORT BrowserConnectionHandler

void OnConnectionError(int error) override;

private:

haibinlu 2015/12/29 00:51:46 why remove this method?

Kevin M 2015/12/30 23:08:49 Done.

- void DropCurrentConnection();

// Routes incoming messages to the relevant feature-specific handlers.

scoped_ptr<BlimpMessageDemultiplexer> demultiplexer_;

@@ -60,7 +58,6 @@ class BLIMP_NET_EXPORT BrowserConnectionHandler

// message stream.

scoped_ptr<BlimpMessageMultiplexer> multiplexer_;

- // Holds network resources while there is a Client connected.

haibinlu 2015/12/29 00:51:46 keep the comment.

Kevin M 2015/12/30 23:08:49 Done.

scoped_ptr<BlimpConnection> connection_;

DISALLOW_COPY_AND_ASSIGN(BrowserConnectionHandler);

« blimp/net/blimp_message_pump.cc ('K') | « blimp/net/blimp_message_pump.cc ('k') | blimp/net/browser_connection_handler.cc » ('j') | blimp/net/browser_connection_handler.cc » ('J')