Implementation and fixes for Blimp client/engine E2E communication.

blimp/net/blimp_message_pump.cc

Index: blimp/net/blimp_message_pump.cc
diff --git a/blimp/net/blimp_message_pump.cc b/blimp/net/blimp_message_pump.cc
index adeed65a6176824edb64f4a4d05160989ce5e090..ae264e1fd8948d68b44bfdab021b7ef6f8e27f46 100644
--- a/blimp/net/blimp_message_pump.cc
+++ b/blimp/net/blimp_message_pump.cc
@@ -30,6 +30,7 @@ BlimpMessagePump::BlimpMessagePump(PacketReader* reader)
 BlimpMessagePump::~BlimpMessagePump() {}
 
 void BlimpMessagePump::SetMessageProcessor(BlimpMessageProcessor* processor) {
+  DVLOG(1) << "SetMessageProcessor, processor=" << processor;
   if (processor && !processor_) {
     processor_ = processor;
     ReadNextPacket();
@@ -43,6 +44,7 @@ void BlimpMessagePump::SetMessageProcessor(BlimpMessageProcessor* processor) {
 }
 
 void BlimpMessagePump::ReadNextPacket() {
+  DVLOG(2) << "ReadNextPacket";
   DCHECK(processor_);
   DCHECK(!read_inflight_);
   read_inflight_ = true;
@@ -51,6 +53,7 @@ void BlimpMessagePump::ReadNextPacket() {
 }
 
 void BlimpMessagePump::OnReadPacketComplete(int result) {
+  DVLOG(2) << "OnReadPacketComplete, result=" << result;
   DCHECK(read_inflight_);
   read_inflight_ = false;
   if (result == net::OK) {
@@ -69,8 +72,13 @@ void BlimpMessagePump::OnReadPacketComplete(int result) {
 }
 
 void BlimpMessagePump::OnProcessMessageComplete(int result) {
-  // No error is expected from the message receiver.
-  DCHECK_EQ(net::OK, result);
+  DVLOG(2) << "OnProcessMessageComplete, result=" << result;
+
+  if (result != net::OK) {

[haibinlu, 2015/12/29 00:51:45]

what causes message process error?
and this is not a connection error.

[Kevin M, 2015/12/30 23:08:49]

The demux can return ERR_NOT_IMPLEMENTED if there are no features available for
the type. Agreed that it's not a connection error, but it is an error condition
that needs to be handled and not ignored, as not processing a feature port will
result in undefined behavior.

+    error_observer_->OnConnectionError(result);
+    return;
+  }
+
   if (processor_)
     ReadNextPacket();
 }