Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: blimp/net/browser_connection_handler.h

Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dtrainor-linux-cl1528243002
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BLIMP_NET_BROWSER_CONNECTION_HANDLER_H_ 5 #ifndef BLIMP_NET_BROWSER_CONNECTION_HANDLER_H_
6 #define BLIMP_NET_BROWSER_CONNECTION_HANDLER_H_ 6 #define BLIMP_NET_BROWSER_CONNECTION_HANDLER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "blimp/common/proto/blimp_message.pb.h" 10 #include "blimp/common/proto/blimp_message.pb.h"
(...skipping 29 matching lines...) Expand all
40 scoped_ptr<BlimpMessageProcessor> RegisterFeature( 40 scoped_ptr<BlimpMessageProcessor> RegisterFeature(
41 BlimpMessage::Type type, 41 BlimpMessage::Type type,
42 BlimpMessageProcessor* incoming_processor); 42 BlimpMessageProcessor* incoming_processor);
43 43
44 // ConnectionHandler implementation. 44 // ConnectionHandler implementation.
45 void HandleConnection(scoped_ptr<BlimpConnection> connection) override; 45 void HandleConnection(scoped_ptr<BlimpConnection> connection) override;
46 46
47 // ConnectionErrorObserver implementation. 47 // ConnectionErrorObserver implementation.
48 void OnConnectionError(int error) override; 48 void OnConnectionError(int error) override;
49 49
50 private: 50 private:
haibinlu 2015/12/29 00:51:46 why remove this method?
Kevin M 2015/12/30 23:08:49 Done.
51 void DropCurrentConnection();
52
53 // Routes incoming messages to the relevant feature-specific handlers. 51 // Routes incoming messages to the relevant feature-specific handlers.
54 scoped_ptr<BlimpMessageDemultiplexer> demultiplexer_; 52 scoped_ptr<BlimpMessageDemultiplexer> demultiplexer_;
55 53
56 // Provides buffering of outgoing messages, for use in session-recovery. 54 // Provides buffering of outgoing messages, for use in session-recovery.
57 scoped_ptr<BlimpMessageOutputBuffer> output_buffer_; 55 scoped_ptr<BlimpMessageOutputBuffer> output_buffer_;
58 56
59 // Routes outgoing messages from feature-specific handlers to a single 57 // Routes outgoing messages from feature-specific handlers to a single
60 // message stream. 58 // message stream.
61 scoped_ptr<BlimpMessageMultiplexer> multiplexer_; 59 scoped_ptr<BlimpMessageMultiplexer> multiplexer_;
62 60
63 // Holds network resources while there is a Client connected.
haibinlu 2015/12/29 00:51:46 keep the comment.
Kevin M 2015/12/30 23:08:49 Done.
64 scoped_ptr<BlimpConnection> connection_; 61 scoped_ptr<BlimpConnection> connection_;
65 62
66 DISALLOW_COPY_AND_ASSIGN(BrowserConnectionHandler); 63 DISALLOW_COPY_AND_ASSIGN(BrowserConnectionHandler);
67 }; 64 };
68 65
69 } // namespace blimp 66 } // namespace blimp
70 67
71 #endif // BLIMP_NET_BROWSER_CONNECTION_HANDLER_H_ 68 #endif // BLIMP_NET_BROWSER_CONNECTION_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698