Implementation and fixes for Blimp client/engine E2E communication.

blimp/net/blimp_message_pump.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/net/blimp_message_pump.h"
 
 #include "base/macros.h"
 #include "blimp/common/proto/blimp_message.pb.h"
 #include "blimp/net/blimp_message_processor.h"
 #include "blimp/net/common.h"
@@ skipping 12 matching lines @@
                      base::Unretained(this))),
       read_callback_(base::Bind(&BlimpMessagePump::OnReadPacketComplete,
                                 base::Unretained(this))) {
   DCHECK(reader_);
   buffer_->SetCapacity(kMaxPacketPayloadSizeBytes);
 }
 
 BlimpMessagePump::~BlimpMessagePump() {}
 
 void BlimpMessagePump::SetMessageProcessor(BlimpMessageProcessor* processor) {
+  DVLOG(1) << "SetMessageProcessor, processor=" << processor;
   if (processor && !processor_) {
     processor_ = processor;
     ReadNextPacket();
   } else {
     // Don't allow |processor_| to be cleared while there's a read inflight.
     if (processor) {
       DCHECK(!processor_ || !read_inflight_);
     }
     processor_ = processor;
   }
 }
 
 void BlimpMessagePump::ReadNextPacket() {
+  DVLOG(2) << "ReadNextPacket";
   DCHECK(processor_);
   DCHECK(!read_inflight_);
   read_inflight_ = true;
   buffer_->set_offset(0);
   reader_->ReadPacket(buffer_.get(), read_callback_.callback());
 }
 
 void BlimpMessagePump::OnReadPacketComplete(int result) {
+  DVLOG(2) << "OnReadPacketComplete, result=" << result;
   DCHECK(read_inflight_);
   read_inflight_ = false;
   if (result == net::OK) {
     scoped_ptr<BlimpMessage> message(new BlimpMessage);
     if (message->ParseFromArray(buffer_->StartOfBuffer(), buffer_->offset())) {
       processor_->ProcessMessage(std::move(message),
                                  process_msg_callback_.callback());
     } else {
       result = net::ERR_FAILED;
     }
   }
 
   if (result != net::OK) {
     error_observer_->OnConnectionError(result);
   }
 }
 
 void BlimpMessagePump::OnProcessMessageComplete(int result) {
-  // No error is expected from the message receiver.
-  DCHECK_EQ(net::OK, result);
+  DVLOG(2) << "OnProcessMessageComplete, result=" << result;
+
+  if (result != net::OK) {

[haibinlu, 2015/12/29 00:51:45]

what causes message process error?
and this is not a connection error.

[Kevin M, 2015/12/30 23:08:49]

The demux can return ERR_NOT_IMPLEMENTED if there are no features available for
the type. Agreed that it's not a connection error, but it is an error condition
that needs to be handled and not ignored, as not processing a feature port will
result in undefined behavior.

+    error_observer_->OnConnectionError(result);
+    return;
+  }
+
   if (processor_)
     ReadNextPacket();
 }
 
 }  // namespace blimp