Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1551313002: Enable -Wformat in linux, android, chromeos, cast builds. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable -Wformat in linux, android, chromeos, cast builds. No behavior change. BUG=573780 Committed: https://crrev.com/932e1e5939963b5b67019f428e8f209246069a44 Cr-Commit-Position: refs/heads/master@{#367353}

Patch Set 1 #

Patch Set 2 : android #

Patch Set 3 : android2 #

Patch Set 4 : linux #

Patch Set 5 : huh #

Patch Set 6 : gnnnn #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/android/file_poller/file_poller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/android/memconsumer/memconsumer_hook.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Nico
4 years, 11 months ago (2016-01-04 15:34:13 UTC) #3
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-04 19:59:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551313002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551313002/120001
4 years, 11 months ago (2016-01-04 20:00:32 UTC) #6
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 11 months ago (2016-01-04 20:07:30 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 20:09:16 UTC) #10
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/932e1e5939963b5b67019f428e8f209246069a44
Cr-Commit-Position: refs/heads/master@{#367353}

Powered by Google App Engine
This is Rietveld 408576698