build/common.gypi - Issue 1551313002: Enable -Wformat in linux, android, chromeos, cast builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1551313002: Enable -Wformat in linux, android, chromeos, cast builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index cbea95780ec9259301466486890457d51b26eb90..4853be3e4d734f786e6f8c2fcd82149f35d669e3 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -3146,11 +3146,6 @@

# Don't warn about hash_map in third-party code.

'-Wno-deprecated',

- 'cflags': [

- # Don't warn about printf format problems.

- # This is off by default in gcc but on in Ubuntu's gcc(!).

- '-Wno-format',

- ],

}],

[ 'os_posix==1 and clang!=1 and OS!="mac" and OS!="ios"', {

# When we don't control the compiler, don't use -Wall for

« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »