build/config/compiler/BUILD.gn - Issue 1551313002: Enable -Wformat in linux, android, chromeos, cast builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1551313002: Enable -Wformat in linux, android, chromeos, cast builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index 732f71aca18612ba8207512b5690e5004d8ab64d..904cdc7ecd768c035a635dcc7fe8114236910333 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -963,11 +963,6 @@ config("no_chromium_code") {

}

if (is_linux || is_android) {

- cflags += [

- # Don't warn about printf format problems. This is off by default in gcc

- # but on in Ubuntu's gcc(!).

- "-Wno-format",

- ]

cflags_cc += [

# Don't warn about hash_map in third-party code.

"-Wno-deprecated",

« no previous file with comments | « build/common.gypi ('k') | tools/android/file_poller/file_poller.cc » ('j') | no next file with comments »