Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1550973002: Fix broken chrome_proxy unit tests (Closed)

Created:
4 years, 11 months ago by bustamante1
Modified:
4 years, 11 months ago
Reviewers:
bengr, sclittle, bustamante
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix broken chrome_proxy unit tests testHTTPResponseTimelineRecorder was failing due to an occasional favicon request which would occassional cause the test to fail. To fix the issue it will now filter out any favicon requests before validation. testChromeProxyMetricForBlockOnce failed to due not being updated when the BlockOnce case was changed. I also renamed the metrics we store in the test to be consistent with other cases. Last item is adding myself to OWNERS for chrome_proxy tests. BUG=452279, 449979, 455269 Committed: https://crrev.com/2464c8bdbf7c59d12a7b8572a82a1eedc7164652 Cr-Commit-Position: refs/heads/master@{#367098}

Patch Set 1 #

Patch Set 2 : Fix lint issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M tools/chrome_proxy/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M tools/chrome_proxy/common/inspector_network_unittest.py View 1 3 chunks +8 lines, -3 lines 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_metrics_unittest.py View 1 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
bustamante
PTAL when you can
4 years, 11 months ago (2015-12-29 19:48:37 UTC) #4
sclittle
LGTM! thanks for fixing these tests
4 years, 11 months ago (2015-12-29 19:52:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550973002/20001
4 years, 11 months ago (2015-12-29 19:54:23 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2015-12-29 20:10:04 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 20:10:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2464c8bdbf7c59d12a7b8572a82a1eedc7164652
Cr-Commit-Position: refs/heads/master@{#367098}

Powered by Google App Engine
This is Rietveld 408576698