tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py - Issue 1550973002: Fix broken chrome_proxy unit tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py

Issue 1550973002: Fix broken chrome_proxy unit tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix lint issues Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py b/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py

index 669168fb92171083c4881f12514dcdf1f6257075..d7578d97656a81f59c5cfdce1c9ab3125fddd6ce 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py

@@ -417,7 +417,7 @@ class ChromeProxyMetric(network_metrics.NetworkMetric):

' test URLs. Expected: 2, Actual: ' + str(eligible_response_count))

results.AddValue(scalar.ScalarValue(results.current_page,

- 'BlockOnce_success', 'num_eligible_response', 2))

+ 'eligible_responses', 'count', 2))

def AddResultsForSafebrowsingOn(self, tab, results):