Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: tools/chrome_proxy/common/inspector_network_unittest.py

Issue 1550973002: Fix broken chrome_proxy unit tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix lint issues Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/chrome_proxy/OWNERS ('k') | tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/chrome_proxy/common/inspector_network_unittest.py
diff --git a/tools/chrome_proxy/common/inspector_network_unittest.py b/tools/chrome_proxy/common/inspector_network_unittest.py
index 0bad858c8aa2a3359f5289e7a1db8df52ffe3e17..6f70d7cb65a30f0987bb05dd06d350b1c8ca5c84 100644
--- a/tools/chrome_proxy/common/inspector_network_unittest.py
+++ b/tools/chrome_proxy/common/inspector_network_unittest.py
@@ -20,6 +20,12 @@ class InspectorNetworkTabTest(tab_test_case.TabTestCase):
def __init__(self, *args):
super(InspectorNetworkTabTest, self).__init__(*args)
+ def _FilterFaviconEvents(self, events):
+ for event in events:
+ if 'favicon.ico' in event.args['response']['url']:
+ events.remove(event)
+ return events
+
def _NavigateAndGetHTTPResponseEvents(self, page):
network = inspector_network.InspectorNetwork(
self._tab._inspector_backend._websocket)
@@ -29,8 +35,6 @@ class InspectorNetworkTabTest(tab_test_case.TabTestCase):
self.assertTrue(timeline_model)
return timeline_model.GetAllEventsOfName('HTTPResponse')
- # crbug.com/449979, crbug.com/452279, crbug.com/455269, crbug.com/483212
- @decorators.Disabled('mac', 'android', 'win', 'linux', 'chromeos')
def testHTTPResponseTimelineRecorder(self):
tests = {
'blank.html': InspectorNetworkTabTest.TestCase(responses_count=1),
@@ -39,7 +43,8 @@ class InspectorNetworkTabTest(tab_test_case.TabTestCase):
responses_count=2, subresources=['image.png']),
}
for page, test in tests.iteritems():
- events = self._NavigateAndGetHTTPResponseEvents(page)
+ events = self._FilterFaviconEvents(
+ self._NavigateAndGetHTTPResponseEvents(page))
self.assertEqual(test.responses_count, len(events))
# Verify required event fields
« no previous file with comments | « tools/chrome_proxy/OWNERS ('k') | tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698