Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1550483002: Switch to standard integer types in ui/. (Closed)

Created:
4 years, 12 months ago by Avi (use Gerrit)
Modified:
4 years, 12 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, shuchen+watch_chromium.org, dcheng, sievers+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, dmazzoni+watch_chromium.org, stevenjb+watch_chromium.org, qsr+mojo_chromium.org, tapted, Matt Giuca, aboxhall+watch_chromium.org, ben+mojo_chromium.org, jam, extensions-reviews_chromium.org, abarth-chromium, jbauman+watch_chromium.org, nona+watch_chromium.org, je_julie, darin-cc_chromium.org, darin (slow to review), kalyank, ozone-reviews_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, yuzo+watch_chromium.org, yzshen+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, plundblad+watch_chromium.org, Ian Vollick, tfarina, nektar+watch_chromium.org, Aaron Boodman, dtseng+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@int-ui-events
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in ui/. BUG=138542 TBR=sky@chromium.org Committed: https://crrev.com/9c81217bffbc7aa8b5aad2054099d60407a1efb4 Cr-Commit-Position: refs/heads/master@{#366842}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+384 lines, -221 lines) Patch
M ui/accelerated_widget_mac/accelerated_widget_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accelerated_widget_mac/display_link_mac.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M ui/accelerated_widget_mac/io_surface_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/accelerated_widget_mac/surface_handle_types.h View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/accelerated_widget_mac/surface_handle_types.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M ui/accelerated_widget_mac/window_resize_helper_mac.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M ui/accessibility/ax_generated_tree_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/ax_node.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/accessibility/ax_node.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/accessibility/ax_node_data.h View 4 chunks +10 lines, -8 lines 0 comments Download
M ui/accessibility/ax_node_data.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M ui/accessibility/ax_serializable_tree.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/accessibility/ax_text_utils.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/accessibility/ax_text_utils_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/accessibility/ax_tree.h View 5 chunks +7 lines, -5 lines 0 comments Download
M ui/accessibility/ax_tree.cc View 6 chunks +13 lines, -9 lines 0 comments Download
M ui/accessibility/ax_tree_data.h View 3 chunks +8 lines, -6 lines 0 comments Download
M ui/accessibility/ax_tree_serializer.h View 8 chunks +11 lines, -8 lines 0 comments Download
M ui/accessibility/ax_tree_serializer_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/accessibility/ax_tree_source.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/accessibility/ax_tree_unittest.cc View 2 chunks +16 lines, -13 lines 0 comments Download
M ui/accessibility/ax_tree_update.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/accessibility/ax_view_state.h View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_auralinux.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_auralinux.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/android/edge_effect.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/android/edge_effect_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/android/overscroll_glow.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/android/resources/resource_manager_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/android/resources/resource_manager_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/android/resources/resource_manager_impl_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/android/ui_android_jni_registrar.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/android/window_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura_extra/image_window_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/ime/candidate_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/ime/candidate_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/ime/candidate_view_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/chromeos/ime/candidate_window_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/ime/candidate_window_view.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/chromeos/ime/candidate_window_view_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/chromeos/ime/infolist_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/ime/infolist_window.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/chromeos/ime/input_method_menu_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/ime/input_method_menu_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/chromeos/ime/mode_indicator_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/ime/mode_indicator_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/network/network_connect.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/network/network_connect.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/network/network_icon.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/network/network_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/network/network_list.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/chromeos/network/network_state_notifier.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/chromeos/network/network_state_notifier_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/chromeos/touch_exploration_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/touch_exploration_controller_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/chromeos/user_activity_power_manager_notifier.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/content_accelerators/accelerator_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/content_accelerators/accelerator_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager_resource_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_bindings.h View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M ui/keyboard/content/keyboard_content_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/keyboard/content/keyboard_content_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/content/keyboard_ui_content.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/content/keyboard_ui_content.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/keyboard_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/keyboard_layout_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/keyboard/keyboard_util_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_center_view.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/metro_viewer/ime_types.h View 4 chunks +10 lines, -9 lines 0 comments Download
M ui/metro_viewer/metro_viewer_messages.h View 10 chunks +46 lines, -47 lines 0 comments Download
M ui/mojo/init/screen_mojo.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/mojo/init/ui_init.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/mojo/init/ui_init.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/native_theme/native_theme_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/native_theme/native_theme_aura.h View 2 chunks +9 lines, -7 lines 0 comments Download
M ui/native_theme/native_theme_aura.cc View 5 chunks +22 lines, -21 lines 0 comments Download
M ui/native_theme/native_theme_aurawin.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_dark_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/native_theme/native_theme_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ui/native_theme/native_theme_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/platform_window/stub/stub_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/platform_window/win/win_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/platform_window/x11/x11_window.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/shell_dialogs/android/shell_dialogs_jni_registrar.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/shell_dialogs/base_shell_dialog_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_mac.mm View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_win_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/snapshot/screenshot_grabber.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/snapshot/screenshot_grabber.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/snapshot/snapshot_async.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/surface/accelerated_surface_mac.h View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/surface/accelerated_surface_mac.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/surface/transport_dib.h View 3 chunks +7 lines, -3 lines 0 comments Download
M ui/surface/transport_dib_posix.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ui/surface/transport_dib_win.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/touch_selection/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/touch_selection/touch_handle.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/touch_selection/touch_handle_drawable_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/touch_selection/touch_selection_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/touch_selection/touch_selection_controller_test_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/touch_selection/touch_selection_controller_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/touch_selection/ui_touch_selection_export.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views_content_client/views_content_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views_content_client/views_content_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views_content_client/views_content_client_main_parts_chromeos.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views_content_client/views_content_client_main_parts_desktop_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views_content_client/views_content_client_main_parts_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views_content_client/views_content_main_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/web_dialogs/test/test_web_contents_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/web_dialogs/test/test_web_dialog_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/web_dialogs/web_dialog_ui.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/web_dialogs/web_dialog_web_contents_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
commit-bot: I haz the power
This CL has an open dependency (Issue 1549553004 Patch 1). Please resolve the dependency and ...
4 years, 12 months ago (2015-12-24 02:09:48 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550483002/1
4 years, 12 months ago (2015-12-24 02:21:59 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/30599) linux_chromium_gn_chromeos_rel on ...
4 years, 12 months ago (2015-12-24 02:35:11 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550483002/20001
4 years, 12 months ago (2015-12-24 16:38:29 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/2421) linux_chromium_gn_chromeos_rel on ...
4 years, 12 months ago (2015-12-24 16:45:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550483002/40001
4 years, 12 months ago (2015-12-24 21:50:11 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/2447) android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, ...
4 years, 12 months ago (2015-12-24 21:54:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550483002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550483002/60001
4 years, 12 months ago (2015-12-24 22:09:46 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/2457) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 12 months ago (2015-12-24 22:14:18 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550483002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550483002/80001
4 years, 12 months ago (2015-12-24 22:28:26 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 12 months ago (2015-12-24 23:40:17 UTC) #22
commit-bot: I haz the power
4 years, 12 months ago (2015-12-24 23:41:19 UTC) #24
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9c81217bffbc7aa8b5aad2054099d60407a1efb4
Cr-Commit-Position: refs/heads/master@{#366842}

Powered by Google App Engine
This is Rietveld 408576698