(reland)WebGL 2: generate appropriate error for different dimensions of images attached to fbo

WebGL 2: generate appropriate error for different dimensions of images attached to fbo.
This change fixed the bug in framebuffer-object-attachment.html

BUG=295792
TEST=conformance2/renderbuffers/framebuffer-object-attachment.html

Committed: https://crrev.com/23cf53ece33a651b28a1d87e57f02a14f22d3c3d
Cr-Commit-Position: refs/heads/master@{#367053}

Committed: https://crrev.com/d5ccdf12f8f65b6dcaad74acc86aa76e2ed015d5
Cr-Commit-Position: refs/heads/master@{#367132}

[yunchao, 2015-12-28 14:52:21]

Description was changed from

==========
WebGL 2: generate proper error for different dimensions of images attached to
fbo

BUG=
==========

to

==========
WebGL 2: generate appropriate error for different dimensions of images attached
to fbo.
This change fixed the bug in 
framebuffer-object-attachment.html

BUG=295792
TEST=conformance2/renderbuffers/framebuffer-object-attachment.html
==========

[yunchao, 2015-12-28 14:52:22]

yunchao.he@intel.com changed reviewers:
+ bajones@chromium.org, kbr@chromium.org, qiankun.miao@intel.com,
zmo@chromium.org

[yunchao, 2015-12-28 14:52:45]

Description was changed from

==========
WebGL 2: generate appropriate error for different dimensions of images attached
to fbo.
This change fixed the bug in 
framebuffer-object-attachment.html

BUG=295792
TEST=conformance2/renderbuffers/framebuffer-object-attachment.html
==========

to

==========
WebGL 2: generate appropriate error for different dimensions of images attached
to fbo.
This change fixed the bug in framebuffer-object-attachment.html

BUG=295792
TEST=conformance2/renderbuffers/framebuffer-object-attachment.html
==========

[yunchao, 2015-12-28 15:18:34]

I saw your discussions in Khronos WebGL mail list. And Zhenyao have updated the
spec & conformance test at https://github.com/KhronosGroup/WebGL/pull/1326 one
month ago. This change try to update the implementation in Blink.

PTAL. Thanks!

[Zhenyao Mo, 2015-12-28 19:16:12]

On 2015/12/28 15:18:34, yunchao wrote:
> I saw your discussions in Khronos WebGL mail list. And Zhenyao have updated
the
> spec & conformance test at https://github.com/KhronosGroup/WebGL/pull/1326 one
> month ago. This change try to update the implementation in Blink.
> 
> PTAL. Thanks!

lgtm

[yunchao, 2015-12-29 00:09:46]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-29 00:10:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549393002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549393002/1

[commit-bot: I haz the power, 2015-12-29 01:17:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-29 01:17:17]

Dry run: This issue passed the CQ dry run.

[yunchao, 2015-12-29 05:03:01]

The CQ bit was checked by yunchao.he@intel.com

[commit-bot: I haz the power, 2015-12-29 05:03:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549393002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549393002/1

[commit-bot: I haz the power, 2015-12-29 05:07:21]

Description was changed from

==========
WebGL 2: generate appropriate error for different dimensions of images attached
to fbo.
This change fixed the bug in framebuffer-object-attachment.html

BUG=295792
TEST=conformance2/renderbuffers/framebuffer-object-attachment.html
==========

to

==========
WebGL 2: generate appropriate error for different dimensions of images attached
to fbo.
This change fixed the bug in framebuffer-object-attachment.html

BUG=295792
TEST=conformance2/renderbuffers/framebuffer-object-attachment.html
==========

[commit-bot: I haz the power, 2015-12-29 05:07:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-29 05:08:43]

Description was changed from

==========
WebGL 2: generate appropriate error for different dimensions of images attached
to fbo.
This change fixed the bug in framebuffer-object-attachment.html

BUG=295792
TEST=conformance2/renderbuffers/framebuffer-object-attachment.html
==========

to

==========
WebGL 2: generate appropriate error for different dimensions of images attached
to fbo.
This change fixed the bug in framebuffer-object-attachment.html

BUG=295792
TEST=conformance2/renderbuffers/framebuffer-object-attachment.html

Committed: https://crrev.com/23cf53ece33a651b28a1d87e57f02a14f22d3c3d
Cr-Commit-Position: refs/heads/master@{#367053}
==========

[commit-bot: I haz the power, 2015-12-29 05:08:43]

Patchset 1 (id:??) landed as
https://crrev.com/23cf53ece33a651b28a1d87e57f02a14f22d3c3d
Cr-Commit-Position: refs/heads/master@{#367053}

[Geoff Lang, 2015-12-29 14:45:59]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1555543002/ by geofflang@chromium.org.

The reason for reverting is: This broke the
WebglConformance.conformance2_rendering_draw_buffers test on mac..

[Geoff Lang, 2015-12-29 14:46:59]

geofflang@chromium.org changed reviewers:
+ geofflang@chromium.org

[Geoff Lang, 2015-12-29 14:46:59]

Example failure:
http://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Release%2...

[yunchao, 2015-12-29 15:50:09]

On 2015/12/29 14:46:59, Geoff Lang wrote:
> Example failure:
>
http://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Release%2...

After a quick scan, it seems that the failure is caused by the test case itself.
We didn't follow GLES3.0 spec now when images attached to fbo have different
sizes. We should generate glError. I have tested conformance tests on Linux
desktop. Unfortunately, draw-buffers.html can not pass in linux, there are lots
of failures (but draw-buffer.html can pass in Mac), so I didn't catch this
failure. Sorry. I will fix the bugs in draw-buffers.html soon.

[Geoff Lang, 2015-12-29 17:41:26]

On 2015/12/29 15:50:09, yunchao wrote:
> On 2015/12/29 14:46:59, Geoff Lang wrote:
> > Example failure:
> >
>
http://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Release%2...
> 
> After a quick scan, it seems that the failure is caused by the test case
itself.
> We didn't follow GLES3.0 spec now when images attached to fbo have different
> sizes. We should generate glError. I have tested conformance tests on Linux
> desktop. Unfortunately, draw-buffers.html can not pass in linux, there are
lots
> of failures (but draw-buffer.html can pass in Mac), so I didn't catch this
> failure. Sorry. I will fix the bugs in draw-buffers.html soon.

No problem, there are no trybots for this test yet so it's hard to catch before
landing.

[Zhenyao Mo, 2015-12-29 21:05:13]

Can we reland the reverted CL with the test marked as fail on Mac, and remove
the entry when we fix the test from upstream and roll in?

[yunchao, 2015-12-30 00:07:20]

Description was changed from

==========
WebGL 2: generate appropriate error for different dimensions of images attached
to fbo.
This change fixed the bug in framebuffer-object-attachment.html

BUG=295792
TEST=conformance2/renderbuffers/framebuffer-object-attachment.html

Committed: https://crrev.com/23cf53ece33a651b28a1d87e57f02a14f22d3c3d
Cr-Commit-Position: refs/heads/master@{#367053}
==========

to

==========
WebGL 2: generate appropriate error for different dimensions of images attached
to fbo.
This change fixed the bug in framebuffer-object-attachment.html

BUG=295792
TEST=conformance2/renderbuffers/framebuffer-object-attachment.html

Committed: https://crrev.com/23cf53ece33a651b28a1d87e57f02a14f22d3c3d
Cr-Commit-Position: refs/heads/master@{#367053}
==========

[yunchao, 2015-12-30 00:17:59]

On 2015/12/29 21:05:13, Zhenyao Mo wrote:
> Can we reland the reverted CL with the test marked as fail on Mac, and remove
> the entry when we fix the test from upstream and roll in?

OK, then we don't need to wait for the roll-in. Code has been updated now,
Zhenyao, PTAL.

[Zhenyao Mo, 2015-12-30 00:28:21]

lgtm

[yunchao, 2015-12-30 00:35:33]

The CQ bit was checked by yunchao.he@intel.com

[commit-bot: I haz the power, 2015-12-30 00:35:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549393002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549393002/20001

[commit-bot: I haz the power, 2015-12-30 02:06:02]

Description was changed from

==========
WebGL 2: generate appropriate error for different dimensions of images attached
to fbo.
This change fixed the bug in framebuffer-object-attachment.html

BUG=295792
TEST=conformance2/renderbuffers/framebuffer-object-attachment.html

Committed: https://crrev.com/23cf53ece33a651b28a1d87e57f02a14f22d3c3d
Cr-Commit-Position: refs/heads/master@{#367053}
==========

to

==========
WebGL 2: generate appropriate error for different dimensions of images attached
to fbo.
This change fixed the bug in framebuffer-object-attachment.html

BUG=295792
TEST=conformance2/renderbuffers/framebuffer-object-attachment.html

Committed: https://crrev.com/23cf53ece33a651b28a1d87e57f02a14f22d3c3d
Cr-Commit-Position: refs/heads/master@{#367053}
==========

[commit-bot: I haz the power, 2015-12-30 02:06:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-30 02:06:46]

Description was changed from

==========
WebGL 2: generate appropriate error for different dimensions of images attached
to fbo.
This change fixed the bug in framebuffer-object-attachment.html

BUG=295792
TEST=conformance2/renderbuffers/framebuffer-object-attachment.html

Committed: https://crrev.com/23cf53ece33a651b28a1d87e57f02a14f22d3c3d
Cr-Commit-Position: refs/heads/master@{#367053}
==========

to

==========
WebGL 2: generate appropriate error for different dimensions of images attached
to fbo.
This change fixed the bug in framebuffer-object-attachment.html

BUG=295792
TEST=conformance2/renderbuffers/framebuffer-object-attachment.html

Committed: https://crrev.com/23cf53ece33a651b28a1d87e57f02a14f22d3c3d
Cr-Commit-Position: refs/heads/master@{#367053}

Committed: https://crrev.com/d5ccdf12f8f65b6dcaad74acc86aa76e2ed015d5
Cr-Commit-Position: refs/heads/master@{#367132}
==========

[commit-bot: I haz the power, 2015-12-30 02:06:46]

Patchset 2 (id:??) landed as
https://crrev.com/d5ccdf12f8f65b6dcaad74acc86aa76e2ed015d5
Cr-Commit-Position: refs/heads/master@{#367132}