third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h - Issue 1549393002: (reland)WebGL 2: generate appropriate error for different dimensions of images attached to fbo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

Issue 1549393002: (reland)WebGL 2: generate appropriate error for different dimensions of images attached to fbo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed zmo@'s feedback: mark draw-buffers.html as failed, will update the test expectation later Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/test/gpu/gpu_tests/webgl2_conformance_expectations.py ('k') | third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

index 1b61c5d47b07edb10ed973331f6be0356efc5968..6c12e911d73846d862c059283f66bc6abe2bb64f 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

@@ -43,6 +43,7 @@ public:

virtual GLsizei width() const = 0;

virtual GLsizei height() const = 0;

+ virtual GLsizei depth() const = 0;

virtual GLenum format() const = 0;

// For texture attachment, type() returns the type of the attached texture.

// For renderbuffer attachment, the type of the renderbuffer may vary with GL implementation.