Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

Issue 1549393002: (reland)WebGL 2: generate appropriate error for different dimensions of images attached to fbo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed zmo@'s feedback: mark draw-buffers.html as failed, will update the test expectation later Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 25 matching lines...) Expand all
36 36
37 class WebGLFramebuffer final : public WebGLContextObject { 37 class WebGLFramebuffer final : public WebGLContextObject {
38 DEFINE_WRAPPERTYPEINFO(); 38 DEFINE_WRAPPERTYPEINFO();
39 public: 39 public:
40 class WebGLAttachment : public GarbageCollectedFinalized<WebGLAttachment> { 40 class WebGLAttachment : public GarbageCollectedFinalized<WebGLAttachment> {
41 public: 41 public:
42 virtual ~WebGLAttachment(); 42 virtual ~WebGLAttachment();
43 43
44 virtual GLsizei width() const = 0; 44 virtual GLsizei width() const = 0;
45 virtual GLsizei height() const = 0; 45 virtual GLsizei height() const = 0;
46 virtual GLsizei depth() const = 0;
46 virtual GLenum format() const = 0; 47 virtual GLenum format() const = 0;
47 // For texture attachment, type() returns the type of the attached textu re. 48 // For texture attachment, type() returns the type of the attached textu re.
48 // For renderbuffer attachment, the type of the renderbuffer may vary wi th GL implementation. 49 // For renderbuffer attachment, the type of the renderbuffer may vary wi th GL implementation.
49 // To avoid confusion, it would be better to not implement type() for re nderbuffer attachment and 50 // To avoid confusion, it would be better to not implement type() for re nderbuffer attachment and
50 // we should always use the internalformat of the renderbuffer and avoid using type() API. 51 // we should always use the internalformat of the renderbuffer and avoid using type() API.
51 virtual GLenum type() const = 0; 52 virtual GLenum type() const = 0;
52 virtual bool isCubeComplete() const = 0; 53 virtual bool isCubeComplete() const = 0;
53 virtual WebGLSharedObject* object() const = 0; 54 virtual WebGLSharedObject* object() const = 0;
54 virtual bool isSharedObject(WebGLSharedObject*) const = 0; 55 virtual bool isSharedObject(WebGLSharedObject*) const = 0;
55 virtual bool valid() const = 0; 56 virtual bool valid() const = 0;
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 143
143 Vector<GLenum> m_drawBuffers; 144 Vector<GLenum> m_drawBuffers;
144 Vector<GLenum> m_filteredDrawBuffers; 145 Vector<GLenum> m_filteredDrawBuffers;
145 146
146 GLenum m_readBuffer; 147 GLenum m_readBuffer;
147 }; 148 };
148 149
149 } // namespace blink 150 } // namespace blink
150 151
151 #endif // WebGLFramebuffer_h 152 #endif // WebGLFramebuffer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698