Take care fall-through cases of switch in pdfium

Take care fall-through cases of switch in pdfium

Found with Clang's -Wimplicit-fallthrough option by tzik@chromium.org.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/de0387c3690ca147482ed943c70eeb828b6dd732

[tzik, 2015-12-27 23:24:34]

tzik@chromium.org changed reviewers:
+ thestig@chromium.org

[tzik, 2015-12-27 23:27:30]

PTAL.
Clang emits warnings on -Wimplicit-fallthrough option, and some of them look
real bugs to me.
Can I make a quick fix for them?

[Lei Zhang, 2015-12-28 02:21:32]

lgtm, do you want me to land this for you?

[tzik, 2015-12-28 02:45:22]

On 2015/12/28 02:21:32, Lei Zhang wrote:
> lgtm, do you want me to land this for you?

Yes, if you are sure it's correct.

[Lei Zhang, 2015-12-28 20:55:01]

https://codereview.chromium.org/1549283002/diff/1/fpdfsdk/src/formfiller/FFL_...
File fpdfsdk/src/formfiller/FFL_FormFiller.cpp (right):

https://codereview.chromium.org/1549283002/diff/1/fpdfsdk/src/formfiller/FFL_...
fpdfsdk/src/formfiller/FFL_FormFiller.cpp:276: break;
This regressed in commit ac67d4765a8ac36cd00c9fc8b6f2b80a3e1cff72, thanks for
catching it.

https://codereview.chromium.org/1549283002/diff/1/fpdfsdk/src/javascript/JS_G...
File fpdfsdk/src/javascript/JS_GlobalData.cpp (right):

https://codereview.chromium.org/1549283002/diff/1/fpdfsdk/src/javascript/JS_G...
fpdfsdk/src/javascript/JS_GlobalData.cpp:54: } break;
This should be fixed, but it does not matter so much because this is dead code
and I'm debating whether to remove it or to implement code to call it.

[Lei Zhang, 2015-12-28 21:07:38]

Description was changed from

==========
Take care fall-through cases of switch in pdfium
==========

to

==========
Take care fall-through cases of switch in pdfium

Found with Clang's -Wimplicit-fallthrough option by tzik@chromium.org.
==========

[Lei Zhang, 2015-12-28 21:07:56]

Description was changed from

==========
Take care fall-through cases of switch in pdfium

Found with Clang's -Wimplicit-fallthrough option by tzik@chromium.org.
==========

to

==========
Take care fall-through cases of switch in pdfium

Found with Clang's -Wimplicit-fallthrough option by tzik@chromium.org.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/de0387c3690ca147482ed943c70eeb828b6d...
==========

[Lei Zhang, 2015-12-28 21:07:57]

Committed patchset #1 (id:1) manually as
de0387c3690ca147482ed943c70eeb828b6dd732 (presubmit successful).