fpdfsdk/src/formfiller/FFL_FormFiller.cpp - Issue 1549283002: Take care fall-through cases of switch in pdfium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/formfiller/FFL_FormFiller.cpp

Issue 1549283002: Take care fall-through cases of switch in pdfium (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/formfiller/FFL_FormFiller.cpp

diff --git a/fpdfsdk/src/formfiller/FFL_FormFiller.cpp b/fpdfsdk/src/formfiller/FFL_FormFiller.cpp

index 2e0451c0f6a360f34371219bc9a340fcb5ea58ad..ae99edbf8703a9102b8e42b3a71c20df26522a6d 100644

--- a/fpdfsdk/src/formfiller/FFL_FormFiller.cpp

+++ b/fpdfsdk/src/formfiller/FFL_FormFiller.cpp

@@ -273,8 +273,10 @@ void CFFL_FormFiller::KillFocusForAnnot(CPDFSDK_Annot* pAnnot, FX_UINT nFlag) {

case FIELDTYPE_CHECKBOX:

case FIELDTYPE_RADIOBUTTON:

bDestroyPDFWindow = TRUE;

+ break;

Lei Zhang 2015/12/28 20:55:00 This regressed in commit ac67d4765a8ac36cd00c9fc8b

default:

bDestroyPDFWindow = FALSE;

+ break;

}

EscapeFiller(pPageView, bDestroyPDFWindow);

}