Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1587)

Unified Diff: fpdfsdk/src/javascript/JS_GlobalData.cpp

Issue 1549283002: Take care fall-through cases of switch in pdfium (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fpdfsdk/src/javascript/JS_GlobalData.cpp
diff --git a/fpdfsdk/src/javascript/JS_GlobalData.cpp b/fpdfsdk/src/javascript/JS_GlobalData.cpp
index 474886c4846c85b1f287abca441d230d16d3fba1..4d6edc898d58152a93f7c5a03e4a570422ba33c0 100644
--- a/fpdfsdk/src/javascript/JS_GlobalData.cpp
+++ b/fpdfsdk/src/javascript/JS_GlobalData.cpp
@@ -51,13 +51,13 @@ void CJS_GlobalVariableArray::Copy(const CJS_GlobalVariableArray& array) {
pNewObjData->nType = pOldObjData->nType;
pNewObjData->objData.Copy(pOldObjData->objData);
Add(pNewObjData);
- }
+ } break;
Lei Zhang 2015/12/28 20:55:00 This should be fixed, but it does not matter so mu
case JS_GLOBALDATA_TYPE_NULL: {
CJS_KeyValue* pNewObjData = new CJS_KeyValue;
pNewObjData->sKey = pOldObjData->sKey;
pNewObjData->nType = pOldObjData->nType;
Add(pNewObjData);
- }
+ } break;
}
}
}
« fpdfsdk/src/formfiller/FFL_FormFiller.cpp ('K') | « fpdfsdk/src/formfiller/FFL_FormFiller.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698