chrome/browser/extensions/api/permissions/permissions_api_helpers.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api_helpers.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc ('k') | chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/permissions/permissions_api_helpers.cc

diff --git a/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc b/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc

index 39673f7ea4994cd1f098e13e41280fecaa44133e..22c3b41c06080ff61308bf0284dd084046fc8dde 100644

--- a/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc

+++ b/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc

@@ -60,7 +60,7 @@ scoped_ptr<Permissions> PackPermissionSet(const PermissionSet& set) {

for (const URLPattern& pattern : set.explicit_hosts())

permissions->origins->push_back(pattern.GetAsString());

- return permissions.Pass();

+ return permissions;

}

scoped_ptr<const PermissionSet> UnpackPermissionSet(