chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/omnibox/omnibox_api.cc ('k') | chrome/browser/extensions/api/permissions/permissions_api_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc b/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

index c5565a1b034a0fc3cd54168737b62e090d34d970..dfd7abbb0ce09b8cd0c2fc0fa3175170da75517d 100644

--- a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h"

+#include <utility>

#include <vector>

#include "base/bind.h"

@@ -86,7 +87,7 @@ void PasswordsPrivateEventRouter::SendSavedPasswordListToListeners() {

new Event(events::PASSWORDS_PRIVATE_ON_SAVED_PASSWORDS_LIST_CHANGED,

api::passwords_private::OnSavedPasswordsListChanged::kEventName,

cached_saved_password_parameters_->CreateDeepCopy()));

- event_router_->BroadcastEvent(extension_event.Pass());

+ event_router_->BroadcastEvent(std::move(extension_event));

}

void PasswordsPrivateEventRouter::OnPasswordExceptionsListChanged(

@@ -106,7 +107,7 @@ void PasswordsPrivateEventRouter::SendPasswordExceptionListToListeners() {

events::PASSWORDS_PRIVATE_ON_PASSWORD_EXCEPTIONS_LIST_CHANGED,

api::passwords_private::OnPasswordExceptionsListChanged::kEventName,

cached_password_exception_parameters_->CreateDeepCopy()));

- event_router_->BroadcastEvent(extension_event.Pass());

+ event_router_->BroadcastEvent(std::move(extension_event));

}

void PasswordsPrivateEventRouter::OnPlaintextPasswordFetched(

@@ -124,8 +125,8 @@ void PasswordsPrivateEventRouter::OnPlaintextPasswordFetched(

scoped_ptr<Event> extension_event(new Event(

events::PASSWORDS_PRIVATE_ON_PLAINTEXT_PASSWORD_RETRIEVED,

api::passwords_private::OnPlaintextPasswordRetrieved::kEventName,

- event_value.Pass()));

- event_router_->BroadcastEvent(extension_event.Pass());

+ std::move(event_value)));

+ event_router_->BroadcastEvent(std::move(extension_event));

}

void PasswordsPrivateEventRouter::StartOrStopListeningForChanges() {